[PATCH manager v2 0/1] fix #5327: ceph: osd: create: accept multiple Ceph networks

[Kefu Chai <k.chai@proxmox.com>]

Hi,

this is v2 of my patch [1] for creating OSDs on clusters with more
than one Ceph network. Sorry, when I sent v1 I missed that Max had
already posted a fix for the same bug back in July [2], so now there
are two patches for #5327 on the list. I only noticed while looking
at #8087, which reports the same problem.

Both patches split the network list and accept the node if any of the
subnets has a local address, but they split it differently. Ceph takes
commas and spaces as separators, and the config in #5327 uses a space:

  cluster_network = 192.168.254.10/24 192.168.0.100/24

If I read it right, Max's patch only splits on commas, so this value
would still go to `ip address show to` as one string and fail. This
patch uses split_list(), like monitor creation does, so both work.

With this patch, an empty "cluster_network =" also falls back to
public_network, like Ceph does, instead of skipping the check. And the
error message names the option it checked, so it doesn't say "cluster
network" when the value came from public_network.

Max's patch also warns about a subnet it can't look up and moves on,
which looks intended. Mine fails there, unless an earlier subnet
already matched. Ceph won't start with a network it can't parse
anyway, so I think failing is fine, but I'm happy to switch to a
warning if that's preferred. And if Max's version is the one to keep,
I can drop this and send the space handling on top of his.

I tested it on a three-node lab cluster with comma- and
space-separated lists, a list of /32s like in #8087, a list without
any local subnet, and an empty cluster_network.

Changes since v1:
- add "fix #5327" and mention #8087
- mention in the commit message that spaces work as separators too
- rebase onto current master

[1] https://lore.proxmox.com/pve-devel/20261009031555.3414265-1-k.chai@proxmox.com/
[2] https://lore.proxmox.com/pve-devel/20260728113729.2136104-1-m.carrara@proxmox.com/

Kefu Chai (1):
  fix #5327: ceph: osd: create: accept multiple Ceph networks

 PVE/API2/Ceph/OSD.pm | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

-- 
2.47.3