all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [RFC PATCH proxmox-backup 0/2] fix #7756: avoid qmp 'backup' timeout
Date: Mon, 26 Oct 2026 14:45:57 +0100	[thread overview]
Message-ID: <20261026134559.352926-1-c.ebner@proxmox.com> (raw)

During high load due to parallel backups or slow storage backend on
the PBS, tokio blocking thread pool can become an issue. This is
because fetching of the previous snapshot manifest and index files
may be blocked in the blocking queue for a long time, leading to
exceeded QMP command timeout, especially notable for snapshots with
large index files.

These patches optimize the async reader for content fetching and
draft a possible workaround by fully offloading the file download
handling to a dedicated thread, not offloading it to tokio's blocking
thread pool.

Open question is whether it would make sense to distinguish between
API endpoints with higher priority and ones with lower priority in
general, and offload them to high priority and low priority thread
pools instead of spawning new threads on demand.

Issue was raised again recently in the enterprise support and several
times in the community forum [0-2].

[0] https://forum.proxmox.com/threads/179304/
[1] https://forum.proxmox.com/threads/183380/
[2] https://forum.proxmox.com/threads/185679/

Christian Ebner (2):
  api: optimize content streaming reader for file download
  fix #7756: api: stream file contents via dedicated thread

 src/api2/helpers.rs | 169 ++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 155 insertions(+), 14 deletions(-)

-- 
2.47.3





             reply	other threads:[~2026-10-26 13:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 13:45 Christian Ebner [this message]
2026-10-26 13:45 ` [RFC PATCH proxmox-backup 1/2] api: optimize content streaming reader for file download Christian Ebner
2026-10-26 13:45 ` [RFC PATCH proxmox-backup 2/2] fix #7756: api: stream file contents via dedicated thread Christian Ebner
2026-10-27 10:41 ` [RFC PATCH proxmox-backup 0/2] fix #7756: avoid qmp 'backup' timeout Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261026134559.352926-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal