[PATCH pmg-api 3/6] fix #8231: api: mynetworks: optionally list automatically trusted networks

[Carsten Haerle <carsten.haerle@straightec.de>]

With 'automatic=1' the index also returns the networks that are added
to mynetworks automatically, marked with 'automatic: 1' and a comment
that tells where each entry comes from and where it is configured. A
configured entry for the same network takes precedence.

Without the parameter the result is unchanged, so existing API users
that iterate over and modify the list are not affected.

Signed-off-by: Carsten Haerle <carsten.haerle@straightec.de>
---
 src/PMG/API2/MyNetworks.pm | 44 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 43 insertions(+), 1 deletion(-)

diff --git a/src/PMG/API2/MyNetworks.pm b/src/PMG/API2/MyNetworks.pm
index 565b6f8..30bf448 100644
--- a/src/PMG/API2/MyNetworks.pm
+++ b/src/PMG/API2/MyNetworks.pm
@@ -11,6 +11,7 @@ use PVE::JSONSchema qw(get_standard_option);
 use PVE::RESTHandler;
 use PVE::INotify;
 
+use PMG::Cluster;
 use PMG::Config;
 
 use base qw(PVE::RESTHandler);
@@ -25,7 +26,15 @@ __PACKAGE__->register_method({
     permissions => { check => ['admin', 'audit'] },
     parameters => {
         additionalProperties => 0,
-        properties => {},
+        properties => {
+            automatic => {
+                description => "Also list the networks that are trusted automatically"
+                    . " (local network, default relay, transport hosts).",
+                type => 'boolean',
+                optional => 1,
+                default => 0,
+            },
+        },
     },
     returns => {
         type => 'array',
@@ -33,6 +42,12 @@ __PACKAGE__->register_method({
             type => "object",
             properties => {
                 cidr => { type => 'string' },
+                comment => { type => 'string', optional => 1 },
+                automatic => {
+                    description => "Trusted automatically, cannot be modified here.",
+                    type => 'boolean',
+                    optional => 1,
+                },
             },
         },
         links => [{ rel => 'child', href => "{cidr}" }],
@@ -48,6 +63,33 @@ __PACKAGE__->register_method({
             push @$res, $mynetworks->{$cidr};
         }
 
+        return $res if !$param->{automatic};
+
+        my $cfg = PMG::Config->new();
+        my $nodename = PVE::INotify::nodename();
+        my $int_ip = PMG::Cluster::remote_node_ip($nodename);
+        my $automatic = $cfg->get_automatic_mynetworks($int_ip);
+
+        foreach my $cidr (sort keys %$automatic) {
+            next if $mynetworks->{$cidr}; # a configured entry takes precedence
+
+            my $origin = $automatic->{$cidr};
+            my @why;
+            push @why, "local network of node '$nodename' (Options: Trust Local Network)"
+                if $origin->{local};
+            push @why, "default relay (Relaying)" if $origin->{relay};
+            if (my $domains = $origin->{transport}) {
+                push @why, "transport for " . join(', ', $domains->@*) . " (Transports)";
+            }
+
+            my $entry = {
+                cidr => $cidr,
+                comment => 'automatic: ' . join('; ', @why),
+                automatic => 1,
+            };
+            push @$res, $entry;
+        }
+
         return $res;
     },
 });
-- 
2.53.0