From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id B26991FF0AF for ; Fri, 23 Oct 2026 13:31:37 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 12E91216B2; Fri, 23 Oct 2026 13:31:28 +0200 (CEST) From: Thomas Ellmenreich To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager v2 7/7] api: rename PROXMOX_DEBUG log variable to PDM_LOG Date: Fri, 23 Oct 2026 13:31:18 +0200 Message-ID: <20261023113120.332453-8-t.ellmenreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261023113120.332453-1-t.ellmenreich@proxmox.com> References: <20261023113120.332453-1-t.ellmenreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792755082733 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.389 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: V7LSAZXVFUWTEMQ6NYGYVFLD25UPTEXA X-Message-ID-Hash: V7LSAZXVFUWTEMQ6NYGYVFLD25UPTEXA X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Thomas Ellmenreich X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Update the variable used to set the log level for the privileged and unprivileged datacenter-api. The old 'PROXMOX_DEBUG' variable is replaced by 'PDM_LOG' to match the pattern used by other products. In the case that PROXMOX_DEBUG is still set, a warning will be emitted, notifying the user that the environment variable is no longer in use. Suggested-by: Lukas Wagner Signed-off-by: Thomas Ellmenreich --- server/src/bin/proxmox-datacenter-api/main.rs | 7 ++++++- server/src/bin/proxmox-datacenter-privileged-api.rs | 9 ++++++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/server/src/bin/proxmox-datacenter-api/main.rs b/server/src/bin/proxmox-datacenter-api/main.rs index 1c107b1f..9d04ba91 100644 --- a/server/src/bin/proxmox-datacenter-api/main.rs +++ b/server/src/bin/proxmox-datacenter-api/main.rs @@ -47,11 +47,16 @@ fn main() -> Result<(), Error> { server::env::sanitize_environment_vars(); - proxmox_log::Logger::from_env("PROXMOX_DEBUG", LevelFilter::INFO) + proxmox_log::Logger::from_env("PDM_LOG", LevelFilter::INFO) .journald_on_no_workertask() .tasklog_pbs() .init()?; + // TODO: remove after a few versions + if std::env::var("PROXMOX_DEBUG").is_ok() { + proxmox_log::warn!("PROXMOX_DEBUG is deprecated, please use PDM_LOG instead"); + } + if std::env::args().nth(1).is_some() { bail!("unexpected command line parameters"); } diff --git a/server/src/bin/proxmox-datacenter-privileged-api.rs b/server/src/bin/proxmox-datacenter-privileged-api.rs index 616d9e14..3ead7eb9 100644 --- a/server/src/bin/proxmox-datacenter-privileged-api.rs +++ b/server/src/bin/proxmox-datacenter-privileged-api.rs @@ -27,11 +27,18 @@ fn main() -> Result<(), Error> { server::env::sanitize_environment_vars(); - proxmox_log::Logger::from_env("PROXMOX_DEBUG", LevelFilter::INFO) + proxmox_log::Logger::from_env("PDM_LOG", LevelFilter::INFO) .journald_on_no_workertask() .tasklog_pbs() .init()?; + // TODO: remove after a few versions + if std::env::var("PROXMOX_DEBUG").is_ok() { + proxmox_log::warn!( + "to set the log level, please use the PDM_LOG variable, as it has replaced PROXMOX_DEBUG" + ); + } + proxmox_product_config::init(pdm_config::api_user()?, pdm_config::priv_user()?); create_directories()?; -- 2.47.3