[PATCH qemu-server v2 7/8] vm_reboot: warn when rebooting a VM with `reboot` disabled

[Jakob Klocker <j.klocker@proxmox.com>]

When `reboot` is set to 0, a reboot requested via `qm reboot` or the
API only stops the VM. Log a warning in the task log so users know why
the VM was not restarted.

Signed-off-by: Jakob Klocker <j.klocker@proxmox.com>
---
 src/PVE/QemuServer.pm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 011d175f..f5ba04f0 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -6248,6 +6248,15 @@ sub vm_reboot {
                 my $storecfg = PVE::Storage::config();
                 _do_vm_stop($storecfg, $vmid, undef, undef, $timeout, 1);
 
+                # Load the config only after the stop: a pending change to 'reboot' is applied
+                # when the VM stops, so this is the value that decides whether it gets restarted
+                my $conf = PVE::QemuConfig->load_config($vmid);
+                my $reboot = parse_reboot($conf->{reboot});
+                if (!($reboot->{enabled} // 1)) {
+                    my $rpcenv = PVE::RPCEnvironment::get();
+                    $rpcenv->warn("VM $vmid: reboot is disabled -"
+                        . " the VM was shut down instead of rebooted.");
+                }
             };
             if (my $err = $@) {
                 # avoid that the next normal shutdown will be confused for a reboot
-- 
2.47.3