[PATCH pve-manager v4 21/27] ui: firewall: ipset: add controls for dangling references

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

Add the shared dangling-references action selector to the update dialog
and replace the plain remove button with a confirmation dialog carrying
the same selector to let users choose how to handle dangling references
on config changes.

'force-rename' is not offered. It is meant as an escape hatch to recover
from a partially applied rename, putting it next to the normal actions
makes it too easy to select.

StdRemoveButton cannot pass the extra 'dangling-references' parameter,
so the remove button is switched to a plain button that opens the
shared FirewallObjectRemove dialog.

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 www/manager6/panel/IPSet.js | 80 +++++++++++++++++++++++++++++++++----
 1 file changed, 72 insertions(+), 8 deletions(-)

diff --git a/www/manager6/panel/IPSet.js b/www/manager6/panel/IPSet.js
index d510ae6d..40c1ef4b 100644
--- a/www/manager6/panel/IPSet.js
+++ b/www/manager6/panel/IPSet.js
@@ -67,11 +67,7 @@ Ext.define('PVE.IPSetList', {
             if (!rec || !canEdit) {
                 return;
             }
-            var win = Ext.create('Proxmox.window.Edit', {
-                subject: "IPSet '" + rec.data.name + "'",
-                url: me.base_url,
-                method: 'POST',
-                digest: rec.data.digest,
+            var ipanel = Ext.create('Proxmox.panel.InputPanel', {
                 items: [
                     {
                         xtype: 'hiddenfield',
@@ -92,6 +88,45 @@ Ext.define('PVE.IPSetList', {
                         fieldLabel: gettext('Comment'),
                     },
                 ],
+                advancedItems: [
+                    {
+                        xtype: 'pveFirewallReferenceAction',
+                        preferredValue: 'rename',
+                        referenceActions: [
+                            {
+                                text: gettext('Keep'),
+                                value: 'keep',
+                                description: gettext('Do not touch firewall rules referencing this IPSet.'),
+                            },
+                            {
+                                text: gettext('Disable'),
+                                value: 'disable',
+                                description: gettext('Disable firewall rules referencing this IPSet.'),
+                            },
+                            {
+                                text: gettext('Delete'),
+                                value: 'drop',
+                                description: gettext('Delete firewall rules referencing this IPSet.'),
+                            },
+                            {
+                                text: gettext('Rename'),
+                                value: 'rename',
+                                description: gettext(
+                                    'Rewrite references to this IPSet to point to the new name.',
+                                ),
+                            },
+                        ],
+                    },
+                ],
+            });
+
+            var win = Ext.create('Proxmox.window.Edit', {
+                subject: "IPSet '" + rec.data.name + "'",
+                url: me.base_url,
+                method: 'POST',
+                digest: rec.data.digest,
+                onlineHelp: 'pve_firewall_dangling_references',
+                items: [ipanel],
             });
             win.show();
             win.on('destroy', reload);
@@ -134,11 +169,40 @@ Ext.define('PVE.IPSetList', {
             },
         });
 
-        me.removeBtn = Ext.create('Proxmox.button.StdRemoveButton', {
+        me.removeBtn = Ext.create('Proxmox.button.Button', {
+            text: gettext('Remove'),
+            disabled: true,
+            dangerous: true,
             enableFn: (rec) => canEdit,
             selModel: sm,
-            baseurl: me.base_url + '/',
-            callback: reload,
+            handler: function (btn, event, rec) {
+                Ext.create('PVE.window.FirewallObjectRemove', {
+                    item: { id: rec.data.name },
+                    url: me.base_url + '/' + rec.data.name,
+                    text: Ext.String.format(
+                        gettext("Are you sure you want to remove IPSet '{0}'"),
+                        rec.data.name,
+                    ),
+                    referenceActions: [
+                        {
+                            text: gettext('Keep'),
+                            value: 'keep',
+                            description: gettext('Do not touch firewall rules referencing this IPSet.'),
+                        },
+                        {
+                            text: gettext('Disable'),
+                            value: 'disable',
+                            description: gettext('Disable firewall rules referencing this IPSet.'),
+                        },
+                        {
+                            text: gettext('Delete'),
+                            value: 'drop',
+                            description: gettext('Delete firewall rules referencing this IPSet.'),
+                        },
+                    ],
+                    apiCallDone: reload,
+                }).show();
+            },
         });
 
         Ext.apply(me, {
-- 
2.47.3