From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 036251FF0C0 for ; Wed, 21 Oct 2026 18:41:25 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 932442145A; Wed, 21 Oct 2026 18:41:24 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup 1/2] pbs-key-config: drop useless length check enforce by type Date: Wed, 21 Oct 2026 18:41:11 +0200 Message-ID: <20261021164112.464267-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261021164112.464267-1-c.ebner@proxmox.com> References: <20261021164112.464267-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792600882147 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.500 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HWYAV5LUDFMDJFRREIVVG6U5H63KRBFL X-Message-ID-Hash: HWYAV5LUDFMDJFRREIVVG6U5H63KRBFL X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The fixed size byte slice passed as parameter to the method call already enfoces the length of 32, so checking that is not required. Drop the useless check. Signed-off-by: Christian Ebner --- pbs-key-config/src/lib.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pbs-key-config/src/lib.rs b/pbs-key-config/src/lib.rs index b8e00d227..3147845ca 100644 --- a/pbs-key-config/src/lib.rs +++ b/pbs-key-config/src/lib.rs @@ -125,10 +125,6 @@ impl KeyConfig { /// Creates a new instance, protect raw_key with passphrase. pub fn with_key(raw_key: &[u8; 32], passphrase: &[u8], kdf: Kdf) -> Result { - if raw_key.len() != 32 { - bail!("got strange key length ({} != 32)", raw_key.len()) - } - let salt = proxmox_sys::linux::random_data(32)?; let kdf = match kdf { -- 2.47.3