all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 0/2] fix potential panic on key decryption
Date: Wed, 21 Oct 2026 18:41:10 +0200	[thread overview]
Message-ID: <20261021164112.464267-1-c.ebner@proxmox.com> (raw)

This patches address a useless key length check on a fixed size array
slice as well as an insufficient length check when decrypting the key
data via KeyConfig::decrypt(). The latter will result in a panic when
source and target length mismatch and is now handled as error.

Christian Ebner (2):
  pbs-key-config: drop useless length check enforce by type
  fix: pbs-key-config: do not panic on short decrypted keys

 pbs-key-config/src/lib.rs | 43 +++++++++++++++++++++++++++++++--------
 1 file changed, 35 insertions(+), 8 deletions(-)

-- 
2.47.3





             reply	other threads:[~2026-10-21 16:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 16:41 Christian Ebner [this message]
2026-10-21 16:41 ` [PATCH proxmox-backup 1/2] pbs-key-config: drop useless length check enforce by type Christian Ebner
2026-10-21 16:41 ` [PATCH proxmox-backup 2/2] fix: pbs-key-config: do not panic on short decrypted keys Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261021164112.464267-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal