[PATCH manager v6 3/4] fix #5475: ui: enable configurable window title

[Thomas Ellmenreich <t.ellmenreich@proxmox.com>]

By setting the title property in the cluster ui-settings, the window
title displayed for PVE instances can be changed. The setting is
evaluated on every fetch of the index template, although not every
evaluation causes a refresh of the title as the fqdn is only renewed
every 24h.

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=5475
Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
---
 PVE/Service/pveproxy.pm       | 45 +++++++++++++++++++++++++++++++++++
 www/index.html.tpl            |  2 +-
 www/manager6/UIOptions.js     |  6 +++++
 www/manager6/dc/OptionView.js | 21 ++++++++++++++--
 4 files changed, 71 insertions(+), 3 deletions(-)

diff --git a/PVE/Service/pveproxy.pm b/PVE/Service/pveproxy.pm
index dfdd014c..397e1490 100755
--- a/PVE/Service/pveproxy.pm
+++ b/PVE/Service/pveproxy.pm
@@ -202,6 +202,46 @@ my sub get_path_mtime {
     return $mtime;
 }
 
+my $FQDN_CACHE = {
+    next_refresh => undef,
+    fqdn => undef,
+};
+
+my sub get_window_title_prefix {
+    my ($title_enum, $nodename) = @_;
+
+    if (!defined($title_enum)) {
+        return;
+    }
+
+    my $prefix = eval {
+        if ($title_enum eq "node-and-cluster") {
+            my $clinfo = PVE::Cluster::get_clinfo();
+            my $clustername = $clinfo->{cluster}->{name};
+
+            return "$nodename - $clustername" if $clustername;
+        } elsif ($title_enum eq "fqdn") {
+            my $now = time();
+            if (!$FQDN_CACHE->{next_refresh} || $now >= $FQDN_CACHE->{next_refresh}) {
+                $FQDN_CACHE->{fqdn} = eval { PVE::Tools::get_fqdn($nodename); };
+                if (my $err = $@) {
+                    $FQDN_CACHE->{next_refresh} = $now + 60;
+                    die $err;
+                }
+                $FQDN_CACHE->{next_refresh} = $now + 24 * 60 * 60;
+            }
+
+            return $FQDN_CACHE->{fqdn};
+        }
+    };
+
+    if (my $err = $@) {
+        chomp $err;
+        die "failed to create '$title_enum' window title: $err";
+    }
+    return $prefix;
+}
+
 # NOTE: Requests to those pages are not authenticated so we must be very careful here
 sub get_index {
     my ($nodename, $server, $r, $args) = @_;
@@ -232,6 +272,7 @@ sub get_index {
         }
     }
 
+    my $window_title_prefix;
     my $consent_text;
     eval {
         my $dc_conf = PVE::Cluster::cfs_read_file('datacenter.cfg');
@@ -240,6 +281,8 @@ sub get_index {
         if (!$lang) {
             $lang = $dc_conf->{language} // 'en';
         }
+        $window_title_prefix =
+            get_window_title_prefix($dc_conf->{'ui-settings'}->{'title'}, $nodename);
     };
     warn "$@\n" if $@;
 
@@ -277,6 +320,8 @@ sub get_index {
         console => $args->{console},
         nodename => $nodename,
         arch => PVE::Tools::get_host_dpkg_arch(),
+        window_title => ($window_title_prefix // "$nodename")
+            . " - Proxmox Virtual Environment",
         debug => $debug,
         version => "$version",
         wtversion => $wtversion,
diff --git a/www/index.html.tpl b/www/index.html.tpl
index c18e6411..a45bad39 100644
--- a/www/index.html.tpl
+++ b/www/index.html.tpl
@@ -4,7 +4,7 @@
     <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
     <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=no">
-    <title>[% nodename %] - Proxmox Virtual Environment</title>
+    <title>[% window_title %]</title>
     <link rel="icon" sizes="128x128" href="/pve2/images/logo-128.png" />
     <link rel="apple-touch-icon" sizes="128x128" href="/pve2/images/logo-128.png" />
     <link rel="stylesheet" type="text/css" href="/pve2/ext6/theme-crisp/resources/theme-crisp-all.css?ver=7.0.0" />
diff --git a/www/manager6/UIOptions.js b/www/manager6/UIOptions.js
index 8c4674af..e94a75df 100644
--- a/www/manager6/UIOptions.js
+++ b/www/manager6/UIOptions.js
@@ -90,6 +90,12 @@ Ext.define('PVE.UIOptions', {
         alphabetical: gettext('Alphabetical'),
     },
 
+    titleOptions: {
+        __default__: gettext('Node Name (Default)'),
+        'node-and-cluster': gettext('Node and Cluster Name'),
+        fqdn: gettext('Fully Qualified Domain Name (FQDN)'),
+    },
+
     shouldSortTags: function () {
         return !(PVE.UIOptions.options['tag-style']?.ordering === 'config');
     },
diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
index 4fc18ae7..ebf61270 100644
--- a/www/manager6/dc/OptionView.js
+++ b/www/manager6/dc/OptionView.js
@@ -97,7 +97,14 @@ Ext.define('PVE.dc.OptionView', {
                 if (value === undefined) {
                     return gettext('No Overrides');
                 }
-                return '';
+                let txt = '';
+                if (value.title) {
+                    txt += Ext.String.format(
+                        gettext('Title: {0}'),
+                        PVE.UIOptions.titleOptions[value.title],
+                    );
+                }
+                return txt;
             },
             header: gettext('UI Settings'),
             editor: {
@@ -116,6 +123,7 @@ Ext.define('PVE.dc.OptionView', {
                                 return undefined;
                             }
                             values = values?.['ui-settings'] ?? {};
+                            values.title = values.title || '__default__';
                             return Proxmox.panel.InputPanel.prototype.setValues.call(this, values);
                         },
                         onGetValues: function (values) {
@@ -133,7 +141,16 @@ Ext.define('PVE.dc.OptionView', {
                                 'ui-settings': value,
                             };
                         },
-                        items: [],
+                        items: [
+                            {
+                                xtype: 'proxmoxKVComboBox',
+                                name: 'title',
+                                fieldLabel: gettext('Title'),
+                                comboItems: Object.entries(PVE.UIOptions.titleOptions),
+                                deleteEmpty: true,
+                                defaultValue: '__default__',
+                            },
+                        ],
                     },
                 ],
             },
-- 
2.47.3