all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH storage 1/4] pvesm: extractconfig: allow access for Datastore.Allocate
Date: Mon, 19 Oct 2026 12:57:52 +0200	[thread overview]
Message-ID: <20261019110029.92256-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20261019110029.92256-1-f.ebner@proxmox.com>

The check_volume_access() call checks that the user has 'VM.Backup'
for the owning guest's ID or 'Datastore.Allocate' for the storage. The
latter is the highest possible storage permission. Consider that
enough to extract the configuration even without an explicit
'VM.Backup' permission.

Note that for restoring a backup, only the check_volume_access() call
is used. So this change also better aligns the checks.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/CLI/pvesm.pm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/PVE/CLI/pvesm.pm b/src/PVE/CLI/pvesm.pm
index 1aaa9f3..4b42734 100755
--- a/src/PVE/CLI/pvesm.pm
+++ b/src/PVE/CLI/pvesm.pm
@@ -187,7 +187,6 @@ __PACKAGE__->register_method({
             if (!defined($ownervm)) {
                 die "unable to extract configuration for '$volume' - not a guest backup\n";
             }
-            $rpcenv->check($authuser, "/vms/$ownervm", ['VM.Backup']);
         }
 
         my $config_raw = PVE::Storage::extract_vzdump_config($storage_cfg, $volume);
-- 
2.47.3





  reply	other threads:[~2026-10-19 11:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 10:57 [PATCH-SERIES storage/manager 0/4] fix #8169: backup: extract config: fix regression with backup type check Fiona Ebner
2026-10-19 10:57 ` Fiona Ebner [this message]
2026-10-19 10:57 ` [PATCH storage 2/4] fix #8169: pvesm: extractconfig: " Fiona Ebner
2026-10-19 10:57 ` [PATCH manager 3/4] api: backup: extract config: allow access for Datastore.Allocate Fiona Ebner
2026-10-19 10:57 ` [PATCH manager 4/4] fix #8169: api: backup: extract config: fix regression with backup type check Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261019110029.92256-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal