From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id DF9B31FF0AD for ; Sun, 18 Oct 2026 22:52:31 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id CC3FB214B0; Sun, 18 Oct 2026 22:52:28 +0200 (CEST) From: Parker Wahle DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=regulad.xyz; s=mail; t=1792356734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=KBxQ5jmw12Pjw41JOCW5BlGJciO2aMq5BfD6lBNrS8c=; b=Bp1CJBmCdTTCdKg9yLo9Vr3JsEwn1M60xXaUXG+Sn+jqs0EZ/KAJ7ZF3bIhbT28bBAOPSj l+jOu9gtOzwVzSSkZTAwBdQLRogMJnICaRxr2ra5ItsXXyXNlGODTwR3z12EPYtCfLDCe0 PiCi5x12xvzR16xoqIiXPqmt3tU68CwE5DBfPKGkiwoJ8mvj2pyUA3NCLsrg0/dlo34Mx1 f7X3An0KReRh02/aTUl/rytyL74DDS3X4uVxLn9en+y+nWslfkhu+T73VConG3NErxhUyf pYOJYza5r6i33do6GFf0D+R0Eekt3xJbXE1jSWSiqFgcw6KzT5HR+ryrydFQnw== To: pve-devel@lists.proxmox.com subject: SPAM: [PATCH manager] fix #8193: ceph: pool set: keep min_size when changing size Date: Sun, 18 Oct 2026 16:52:04 -0400 Message-ID: <20261018205203.654-2-regulad@regulad.xyz> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1565; i=regulad@regulad.xyz; h=from:subject; bh=O6zrKbeBEUSRU3GEf44WI6im6tHElioXJapjUbEvQSo=; b=owGbwMvMwCXGIf3U8ZXyms+Mp9WSGLKuGpbc2rh5zqGgFZu/RFw+8viq59w11anMi9hnpZTcD 7sz98+ZuR2lLAxiXAyyYoosZ1jf6JdxJ3vmbRA5DDOHlQlkCAMXpwBMJO83I8O9pdsvbF2d8r1y 5tkJu7hXftor2PL+53nPWX59X/rels+cyciwRGIx06vzzTYCZQfa/AXj+V9slJpc15ZZOG1f3jH /vdZsAA== X-Developer-Key: i=regulad@regulad.xyz; a=openpgp; fpr=CC05EC2F760B63496EB014C3081BE541EA23ACF3 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 5 DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FROM_SUSPICIOUS_NTLD 0.01 From abused NTLD FROM_SUSPICIOUS_NTLD_FP 0.1 From abused NTLD KAM_INFOUSMEBIZ 0.75 Prevalent use of .info|.us|.me|.me.uk|.biz|xyz|id|rocks|life domains in spam/malware KAM_SOMETLD_ARE_BAD_TLD 5 .bar, .beauty, .buzz, .cam, .casa, .cfd, .club, .date, .guru, .link, .live, .monster, .press, .pw, .quest, .rest, .sbs, .shop, .stream, .top, .trade, .wiki, .work, .xyz TLD abuse SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record T_PDS_OTHER_BAD_TLD 0.01 Untrustworthy TLDs Message-ID-Hash: A5BALGALOVSCIU7K4RIJSSFR5VHGI4KL X-Message-ID-Hash: A5BALGALOVSCIU7K4RIJSSFR5VHGI4KL X-MailFrom: regulad@regulad.xyz X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Parker Wahle , "Claude Opus 5.5" X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Since commit 76ed4900 ("fix #5010: ceph: pool set only changed properties"), set_pool reads the pool's properties once, before applying anything, and skips every requested setting that matches them. Ceph resets min_size whenever size changes, which is why set_pool applies size first. But a requested min_size equal to the old one was still compared with the value from before that reset and skipped, so Ceph's reset value stayed in place: for example, size=3 min_size=1 on a size 2 / min_size 1 pool left min_size at 2, and size=3 min_size=3 on a size 4 / min_size 3 pool lowered it to 2. This code change has PVE re-read the pool's properties after setting the size, so the remaining settings are compared with the pool's current values. An LLM was used to isolate the cause of bug #8193 and draft a fix. The fix was then tested against a reproducer on a live node and found to work. Co-Authored-By: Claude Opus 5.5 Signed-off-by: Parker Wahle --- PVE/Ceph/Tools.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/Ceph/Tools.pm b/PVE/Ceph/Tools.pm index 94177709..ad5ba687 100644 --- a/PVE/Ceph/Tools.pm +++ b/PVE/Ceph/Tools.pm @@ -304,6 +304,8 @@ sub set_pool { print "$err"; } else { delete $param->{$setting}; + # Ceph resets min_size when size changes, so re-read before comparing the rest + $current_properties = get_pool_properties($pool, $rados) if $setting eq 'size'; } } -- 2.56.0