[PATCH ha-manager v2 10/14] sim: hardware: allow setting a base load for nodes

[Michael Ryom <Michael@RyomHerold.dk>]

The dynamic node usage stats of the simulated hardware only consisted
of the usage of the running HA-managed services. On a real cluster, the
node usage additionally contains everything else running on the node:
non-HA guests, storage daemons like Ceph or the ZFS ARC, and other host
processes, which fluctuate independently of the HA-managed services.

Read an optional base load ('cpu' and 'mem') for each node from the
hardware status and add a hardware command

    node <node> set-dynamic-stats [cpu <cores>] [mem <MiB>]

to change it during a test, so that regression tests can simulate load
that cannot be attributed to any HA-managed service.

Signed-off-by: Michael Ryom <Michael@RyomHerold.dk>
---
 src/PVE/HA/Sim/Hardware.pm | 30 +++++++++++++++++++++++++++---
 1 file changed, 27 insertions(+), 3 deletions(-)

diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm
index 538bc4e..aa1a886 100644
--- a/src/PVE/HA/Sim/Hardware.pm
+++ b/src/PVE/HA/Sim/Hardware.pm
@@ -791,6 +791,7 @@ sub get_cfs_state {
 #   crm enable-node-maintenance <node>
 #   crm disable-node-maintenance <node>
 #   pve-manager-version <node> set <version>   # note: this is NOT the *ha*-manager version
+#   node <node> set-dynamic-stats [cpu <cores>] [mem <MiB>]  # load outside HA services
 #   reboot <node>
 #   shutdown <node>
 #   restart-lrm <node>
@@ -881,6 +882,26 @@ sub sim_hardware_cmd {
 
             $self->write_hardware_status_nolock($cstatus);
 
+        } elsif ($cmd eq 'node') {
+            die "sim_hardware_cmd: unknown node action '$action'"
+                if $action ne 'set-dynamic-stats';
+            die "sim_hardware_cmd: missing target stat for '$action' command"
+                if !@params;
+
+            my $conversions = { cpu => sub { 0.0 + $_[0] }, mem => sub { $_[0] * 1024**2 } };
+
+            for my ($target, $val) (@params) {
+                die "sim_hardware_cmd: missing value for '$action $target' command"
+                    if !defined($val);
+
+                my $convert = $conversions->{$target}
+                    or die "sim_hardware_cmd: unknown target stat '$target' for '$action' command";
+
+                $cstatus->{$node}->{$target} = $convert->($val);
+            }
+
+            $self->write_hardware_status_nolock($cstatus);
+
         } elsif ($cmd eq 'cfs') {
             die "sim_hardware_cmd: unknown cfs action '$action' for node '$node'"
                 if $action !~ m/^(rw|update)$/;
@@ -1281,18 +1302,21 @@ sub get_static_node_stats {
 sub get_dynamic_node_stats {
     my ($self) = @_;
 
+    my $cstatus = $self->read_hardware_status_nolock();
+
     my $stats = $self->get_static_node_stats();
     for my $node (keys %$stats) {
         $stats->{$node}->{maxcpu} = $stats->{$node}->{maxcpu} // $default_node_maxcpu;
-        $stats->{$node}->{cpu} = $stats->{$node}->{cpu} // 0.0;
+        # base load of the node outside of the HA-managed services, e.g.
+        # non-HA guests or other host processes
+        $stats->{$node}->{cpu} = $cstatus->{$node}->{cpu} // 0.0;
         $stats->{$node}->{maxmem} = $stats->{$node}->{maxmem} // $default_node_maxmem;
-        $stats->{$node}->{mem} = $stats->{$node}->{mem} // 0;
+        $stats->{$node}->{mem} = $cstatus->{$node}->{mem} // 0;
     }
 
     my $service_conf = $self->read_service_config();
     my $dynamic_service_stats = $self->get_dynamic_service_stats();
 
-    my $cstatus = $self->read_hardware_status_nolock();
     my $node_service_status = { map { $_ => $self->read_service_status($_) } keys %$cstatus };
 
     for my $sid (keys %$service_conf) {
-- 
2.47.3