[PATCH ha-manager v4 04/27] update crm commands: align logging with next state started/stopped

[Fiona Ebner <f.ebner@proxmox.com>]

In preparation to factor out a common helper for checking whether a
resource motion is valid.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

New in v4.

 src/PVE/HA/Manager.pm                             | 4 ++--
 src/test/test-node-affinity-nonstrict7/log.expect | 2 +-
 src/test/test-node-affinity-strict7/log.expect    | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
index 5840a76..0aef118 100644
--- a/src/PVE/HA/Manager.pm
+++ b/src/PVE/HA/Manager.pm
@@ -681,12 +681,12 @@ sub update_crm_commands {
             my ($task, $sid, $node) = ($1, $2, $3);
             if (my $sd = $ss->{$sid}) {
                 if (!$ns->node_is_online($node)) {
-                    $haenv->log('err', "crm command error - node not online: $cmd");
+                    $haenv->log('err', "ignore crm command '$cmd' - node '$node' not online");
                 } else {
                     if ($node eq $sd->{node}) {
                         $haenv->log(
                             'info',
-                            "ignore crm command - service already on target node: $cmd",
+                            "ignore crm command '$cmd' - service already on node '$node'",
                         );
                     } else {
                         $self->queue_resource_motion($cmd, $task, $sid, $node);
diff --git a/src/test/test-node-affinity-nonstrict7/log.expect b/src/test/test-node-affinity-nonstrict7/log.expect
index 54e824e..fe9423b 100644
--- a/src/test/test-node-affinity-nonstrict7/log.expect
+++ b/src/test/test-node-affinity-nonstrict7/log.expect
@@ -32,7 +32,7 @@ err     120    node1/crm: crm command 'migrate vm:101 node1' error - service 'vm
 info    220      cmdlist: execute service vm:101 migrate node2
 err     220    node1/crm: crm command 'migrate vm:101 node2' error - service 'vm:101' is not allowed on node 'node2'
 info    320      cmdlist: execute service vm:101 migrate node3
-info    320    node1/crm: ignore crm command - service already on target node: migrate vm:101 node3
+info    320    node1/crm: ignore crm command 'migrate vm:101 node3' - service already on node 'node3'
 info    420      cmdlist: execute service vm:102 migrate node3
 info    420    node1/crm: got crm command: migrate vm:102 node3
 info    420    node1/crm: migrate service 'vm:102' to node 'node3'
diff --git a/src/test/test-node-affinity-strict7/log.expect b/src/test/test-node-affinity-strict7/log.expect
index ae8e43f..21cfb76 100644
--- a/src/test/test-node-affinity-strict7/log.expect
+++ b/src/test/test-node-affinity-strict7/log.expect
@@ -32,11 +32,11 @@ err     120    node1/crm: crm command 'migrate vm:101 node1' error - service 'vm
 info    220      cmdlist: execute service vm:101 migrate node2
 err     220    node1/crm: crm command 'migrate vm:101 node2' error - service 'vm:101' is not allowed on node 'node2'
 info    320      cmdlist: execute service vm:101 migrate node3
-info    320    node1/crm: ignore crm command - service already on target node: migrate vm:101 node3
+info    320    node1/crm: ignore crm command 'migrate vm:101 node3' - service already on node 'node3'
 info    420      cmdlist: execute service vm:102 migrate node3
 err     420    node1/crm: crm command 'migrate vm:102 node3' error - service 'vm:102' is not allowed on node 'node3'
 info    520      cmdlist: execute service vm:102 migrate node2
-info    520    node1/crm: ignore crm command - service already on target node: migrate vm:102 node2
+info    520    node1/crm: ignore crm command 'migrate vm:102 node2' - service already on node 'node2'
 info    620      cmdlist: execute service vm:102 migrate node1
 info    620    node1/crm: got crm command: migrate vm:102 node1
 info    620    node1/crm: migrate service 'vm:102' to node 'node1'
-- 
2.47.3