From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id C6AAB1FF0B3 for ; Wed, 14 Oct 2026 16:44:18 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4EF8621612; Wed, 14 Oct 2026 16:44:07 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v2 08/14] datastore: cleanup persisted statistics during datastore destruction Date: Wed, 14 Oct 2026 16:43:51 +0200 Message-ID: <20261014144357.771051-9-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261014144357.771051-1-c.ebner@proxmox.com> References: <20261014144357.771051-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791989042790 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.529 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YOJQIUWDDLFWQABAYYVJJRR2JTEDAOO7 X-Message-ID-Hash: YOJQIUWDDLFWQABAYYVJJRR2JTEDAOO7 X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Handle the statistics json file when removing a datastore with its contents and assure cleanup does not fail if the file is missing. Signed-off-by: Christian Ebner --- pbs-datastore/src/datastore.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs index 420221585..941e74437 100644 --- a/pbs-datastore/src/datastore.rs +++ b/pbs-datastore/src/datastore.rs @@ -3064,6 +3064,12 @@ impl DataStore { ok = false; } } + if let Err(err) = std::fs::remove_file(base.join(DATASTORE_STATISTICS_FILENAME)) { + if err.kind() != io::ErrorKind::NotFound { + warn!("failed to remove file '{DATASTORE_STATISTICS_FILENAME}': {err}"); + ok = false; + } + } } if let (_backend, Some(s3_client)) = -- 2.47.3