[RFC PATCH network 08/16] sdn: subnets: refuse gateway, snat and dhcp on ovn zones

["Rémi PAETA" <remi.paeta@comaite.com>]

OVN zones do not route nor serve DHCP yet, so a subnet gateway, SNAT or
DHCP ranges would have no effect on them. Refuse them instead of
silently ignoring them.

Signed-off-by: Rémi PAETA <remi.paeta@comaite.com>
---
 src/PVE/Network/SDN/SubnetPlugin.pm |  9 +++++++++
 src/test/run_test_ovn.pl            | 12 ++++++++++++
 2 files changed, 21 insertions(+)

diff --git a/src/PVE/Network/SDN/SubnetPlugin.pm b/src/PVE/Network/SDN/SubnetPlugin.pm
index e2a0e50..7de40aa 100644
--- a/src/PVE/Network/SDN/SubnetPlugin.pm
+++ b/src/PVE/Network/SDN/SubnetPlugin.pm
@@ -217,6 +217,15 @@ sub on_update_hook {
         $mac = $vnet->{mac};
     }
 
+    # OVN zones neither route nor serve DHCP (yet), so these options would have no effect
+    if (($zone->{type} // '') eq 'ovn') {
+        for my $option ('gateway', 'snat', 'dhcp-range') {
+            my $value = $subnet->{$option};
+            next if !$value || (ref($value) eq 'ARRAY' && !@$value);
+            raise_param_exc({ $option => "$option is not supported on OVN zones" });
+        }
+    }
+
     my $pointopoint = Net::IP::ip_is_ipv4($gateway) && $mask == 32;
 
     #for /32 pointopoint, we allow gateway outside the subnet
diff --git a/src/test/run_test_ovn.pl b/src/test/run_test_ovn.pl
index 9f191b3..cb36a0f 100755
--- a/src/test/run_test_ovn.pl
+++ b/src/test/run_test_ovn.pl
@@ -12,6 +12,7 @@ use Test::MockModule;
 use PVE::Network::SDN;
 use PVE::Network::SDN::Ovn;
 use PVE::Network::SDN::Controllers::OvnPlugin;
+use PVE::Network::SDN::SubnetPlugin;
 use PVE::Network::SDN::Zones::OvnPlugin;
 
 my $controller = {
@@ -511,6 +512,17 @@ eval {
 };
 like($@, qr/isolate-ports is not supported/, 'vnet_update_hook: isolate-ports refused');
 
+for my $option (['gateway', '10.0.0.1'], ['snat', 1], ['dhcp-range', ['start-address=a']]) {
+    eval {
+        PVE::Network::SDN::SubnetPlugin->on_update_hook(
+            { type => 'ovn' },
+            'zone1-10.0.0.0-24',
+            { cidr => '10.0.0.0/24', mask => 24, $option->[0] => $option->[1] },
+        );
+    };
+    like($@, qr/$option->[0] is not supported on OVN zones/, "subnet: $option->[0] refused");
+}
+
 # chassis
 
 is(
-- 
2.47.3