From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id E7D7B1FF0B0 for ; Fri, 09 Oct 2026 15:02:25 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 764AA21B0C; Fri, 09 Oct 2026 14:58:13 +0200 (CEST) From: Lukas Wagner To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com Subject: [PATCH common v3 32/39] tools: move version_cmp() helper from qemu-server Date: Fri, 9 Oct 2026 14:56:39 +0200 Message-ID: <20261009125646.284673-33-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261009125646.284673-1-l.wagner@proxmox.com> References: <20261009125646.284673-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791550613464 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.325 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QILNDSYCG5OK5MQ4WJQA2WTKR2OMMBTQ X-Message-ID-Hash: QILNDSYCG5OK5MQ4WJQA2WTKR2OMMBTQ X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Fiona Ebner To be re-used from pve-cluster for node version checking. This helper seems generic enough to warrant inclusion in the PVE::Tools module. There is no module like PVE::Version or similar yet and a module for the single helper seems overkill. Signed-off-by: Fiona Ebner --- Notes: New in v3, cherry-picked from https://lore.proxmox.com/pve-devel/20260918160841.128088-1-f.ebner@proxmox.com/ src/PVE/Tools.pm | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 331de40..347ae50 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -1658,4 +1658,30 @@ sub is_deeply { return 1; } +# gets in pairs the versions you want to compares, i.e.: +# ($a-major, $b-major, $a-minor, $b-minor, $a-extra, $b-extra, ...) +# returns 0 if same, -1 if $a is older than $b, +1 if $a is newer than $b +sub version_cmp { + my @versions = @_; + + my $size = scalar(@versions); + + return 0 if $size == 0; + + if ($size & 1) { + my (undef, $fn, $line) = caller(0); + die "cannot compare odd count of versions, called from $fn:$line\n"; + } + + for (my $i = 0; $i < $size; $i += 2) { + my ($left, $right) = splice(@versions, 0, 2); + $left //= 0; + $right //= 0; + + return 1 if $left > $right; + return -1 if $left < $right; + } + return 0; +} + 1; -- 2.47.3