From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 731271FF0B2 for ; Fri, 09 Oct 2026 11:00:22 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3A3E6213D3; Fri, 09 Oct 2026 11:00:18 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-ve-rs 1/2] fix #7584: ve-config: guest: add missing network interface models Date: Fri, 9 Oct 2026 11:00:03 +0200 Message-ID: <20261009090006.104013-2-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261009090006.104013-1-s.hanreich@proxmox.com> References: <20261009090006.104013-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791536414665 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.632 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VXEP3X6IHQDDOQUWAAMJDJCXVKWF642O X-Message-ID-Hash: VXEP3X6IHQDDOQUWAAMJDJCXVKWF642O X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add models defined in qemu-server to the enum that is parsing the network interface property string. This prevents the parser from failing to parse valid network interface names that are accepted by the qemu-server API. In practice, the e1000e model was the most likely culprit since it is exposed in the UI. Signed-off-by: Stefan Hanreich --- proxmox-ve-config/src/guest/vm.rs | 37 ++++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/proxmox-ve-config/src/guest/vm.rs b/proxmox-ve-config/src/guest/vm.rs index 5c3bbb86..cebcb9e6 100644 --- a/proxmox-ve-config/src/guest/vm.rs +++ b/proxmox-ve-config/src/guest/vm.rs @@ -22,6 +22,16 @@ pub enum NetworkDeviceModel { E1000, Vmxnet3, RTL8139, + E100082540em, + E100082544gc, + E100082545em, + E1000e, + I82551, + I82557b, + I82559er, + Ne2kIsa, + Ne2kPci, + Pcnet, } proxmox_serde::forward_deserialize_to_from_str!(NetworkDeviceModel); @@ -36,6 +46,16 @@ impl FromStr for NetworkDeviceModel { "rtl8139" => Ok(NetworkDeviceModel::RTL8139), "vmxnet3" => Ok(NetworkDeviceModel::Vmxnet3), "veth" => Ok(NetworkDeviceModel::Veth), + "e1000-82540em" => Ok(NetworkDeviceModel::E100082540em), + "e1000-82544gc" => Ok(NetworkDeviceModel::E100082544gc), + "e1000-82545em" => Ok(NetworkDeviceModel::E100082545em), + "e1000e" => Ok(NetworkDeviceModel::E1000e), + "i82551" => Ok(NetworkDeviceModel::I82551), + "i82557b" => Ok(NetworkDeviceModel::I82557b), + "i82559er" => Ok(NetworkDeviceModel::I82559er), + "ne2k_isa" => Ok(NetworkDeviceModel::Ne2kIsa), + "ne2k_pci" => Ok(NetworkDeviceModel::Ne2kPci), + "pcnet" => Ok(NetworkDeviceModel::Pcnet), _ => bail!("Invalid network device model: {s}"), } } @@ -79,7 +99,22 @@ impl ApiType for QemuNetworkDevice { .additional_properties(true) .key_alias_info(KeyAliasInfo::new( "model", - &sorted!(["e1000", "rtl8139", "virtio", "vmxnet3"]), + &sorted!([ + "e1000", + "rtl8139", + "virtio", + "vmxnet3", + "e1000-82540em", + "e1000-82544gc", + "e1000-82545em", + "e1000e", + "i82551", + "i82557b", + "i82559er", + "ne2k_isa", + "ne2k_pci", + "pcnet", + ]), "macaddr", )) .schema(); -- 2.47.3