From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v3 3/8] tests: hotplug: add test case for adding scsi14 on qemu 11.1
Date: Wed, 7 Oct 2026 16:17:55 +0200 [thread overview]
Message-ID: <20261007142145.984970-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20261007142145.984970-1-d.csapak@proxmox.com>
This logic changed recently with commit
ad4d2f5a (cfg2cmd: pci: add pci.4 by default starting with machine version 11.1)
so that we add the necessary bridge by default, let us check this behavior.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/test/hotplug/disk-add-scsi14-qemu11.1.conf | 15 +++++++++++++++
.../disk-add-scsi14-qemu11.1.conf.expected | 6 ++++++
2 files changed, 21 insertions(+)
create mode 100644 src/test/hotplug/disk-add-scsi14-qemu11.1.conf
create mode 100644 src/test/hotplug/disk-add-scsi14-qemu11.1.conf.expected
diff --git a/src/test/hotplug/disk-add-scsi14-qemu11.1.conf b/src/test/hotplug/disk-add-scsi14-qemu11.1.conf
new file mode 100644
index 00000000..9666ecd4
--- /dev/null
+++ b/src/test/hotplug/disk-add-scsi14-qemu11.1.conf
@@ -0,0 +1,15 @@
+# TEST: hotplugging a SCSI disk whose new LSI controller needs pci.4, exists by default since machine 11.1
+# QEMU_VERSION: 11.1.0
+bootdisk: scsi0
+cores: 2
+memory: 2048
+name: hotplug
+net0: virtio=A2:C0:43:77:08:A0,bridge=vmbr0
+ostype: l26
+scsi0: local:8006/vm-8006-disk-0.qcow2,size=32G
+smbios1: uuid=7b10d7af-b932-4c66-b2c3-3996152ec465
+sockets: 1
+vmgenid: c773c261-d800-4348-9f5d-167fadd53cf8
+
+[PENDING]
+scsi14: local:8006/vm-8006-disk-1.qcow2,size=32G
diff --git a/src/test/hotplug/disk-add-scsi14-qemu11.1.conf.expected b/src/test/hotplug/disk-add-scsi14-qemu11.1.conf.expected
new file mode 100644
index 00000000..190ed70b
--- /dev/null
+++ b/src/test/hotplug/disk-add-scsi14-qemu11.1.conf.expected
@@ -0,0 +1,6 @@
+storage activate_volumes ["local:8006/vm-8006-disk-1.qcow2"]
+hmp device_add driver=lsi,id=scsihw2,bus=pci.4,addr=0x1
+qmp object-del {"id":"throttle-drive-scsi14"}
+qmp object-add {"id":"throttle-drive-scsi14","limits":{},"qom-type":"throttle-group"}
+qmp blockdev-add {"detect-zeroes":"on","discard":"ignore","driver":"throttle","file":{"cache":{"direct":true,"no-flush":false},"detect-zeroes":"on","discard":"ignore","driver":"qcow2","file":{"aio":"io_uring","cache":{"direct":true,"no-flush":false},"detect-zeroes":"on","discard":"ignore","driver":"file","filename":"/var/lib/vz/images/8006/vm-8006-disk-1.qcow2","node-name":"efa063c24a1f5d262b573eeb1ba16a3","read-only":false},"node-name":"ffa063c24a1f5d262b573eeb1ba16a3","read-only":false},"node-name":"drive-scsi14","read-only":false,"throttle-group":"throttle-drive-scsi14"}
+hmp device_add driver=scsi-hd,bus=scsihw2.0,scsi-id=0,drive=drive-scsi14,id=scsi14,device_id=drive-scsi14,write-cache=on
--
2.47.3
next prev parent reply other threads:[~2026-10-07 14:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 14:17 [PATCH qemu-server v3 0/8] add hotplug tests and fix uncovered bugs Dominik Csapak
2026-10-07 14:17 ` [PATCH qemu-server v3 1/8] tests: hotplug: add initial hotplug test harness Dominik Csapak
2026-10-07 14:17 ` [PATCH qemu-server v3 2/8] tests: hotplug: add some test cases Dominik Csapak
2026-10-07 14:17 ` Dominik Csapak [this message]
2026-10-07 14:17 ` [PATCH qemu-server v3 4/8] tests: hotplug: add cases for known defects Dominik Csapak
2026-10-07 14:17 ` [PATCH qemu-server v3 5/8] hotplug: fix hot unplugging tablet on aarch64 Dominik Csapak
2026-10-07 14:17 ` [PATCH qemu-server v3 6/8] hotplug: fix vm_deviceplug call for 'tablet' and 'keyboard' " Dominik Csapak
2026-10-07 14:17 ` [PATCH qemu-server v3 7/8] hotplug: remove iothread if adding drive device failed Dominik Csapak
2026-10-07 14:18 ` [PATCH qemu-server v3 8/8] hotplug: name the missing bridge in the error message Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007142145.984970-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.