From: Elias Huhsovitz <e.huhsovitz@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: [PATCH manager 1/2] fix #8093: pvestatd: remove cleanup of stale lxc consoles
Date: Wed, 7 Oct 2026 10:37:25 +0200 [thread overview]
Message-ID: <20261007083726.26067-2-e.huhsovitz@proxmox.com> (raw)
In-Reply-To: <20261007083726.26067-1-e.huhsovitz@proxmox.com>
Responsibility is moved to pve-container.
Signed-off-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
---
PVE/Service/pvestatd.pm | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm
index 34f9da71..cec66e00 100755
--- a/PVE/Service/pvestatd.pm
+++ b/PVE/Service/pvestatd.pm
@@ -444,20 +444,6 @@ sub update_qemu_status {
PVE::PullMetric::update($pull_txn, 'qemu', $vmstatus, $ctime);
}
-sub remove_stale_lxc_consoles {
-
- my $vmstatus = PVE::LXC::vmstatus();
- my $pidhash = PVE::LXC::find_lxc_console_pids();
-
- foreach my $vmid (keys %$pidhash) {
- next if defined($vmstatus->{$vmid});
- syslog('info', "remove stale lxc-console for CT $vmid");
- foreach my $pid (@{ $pidhash->{$vmid} }) {
- kill(9, $pid);
- }
- }
-}
-
my $rebalance_error_count = {};
my $NO_REBALANCE;
@@ -848,10 +834,6 @@ sub update_status {
$err = $@;
syslog('err', "storage status update error: $err") if $err;
- eval { remove_stale_lxc_consoles(); };
- $err = $@;
- syslog('err', "lxc console cleanup error: $err") if $err;
-
eval { rotate_authkeys(); };
$err = $@;
syslog('err', "authkey rotation error: $err") if $err;
--
2.47.3
next prev parent reply other threads:[~2026-10-07 8:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 8:37 [PATCH container/manager 0/2] fix #8093: console: bind console sessions to container lifetime via systemd scopes Elias Huhsovitz
2026-10-07 8:37 ` Elias Huhsovitz [this message]
2026-10-07 8:37 ` [PATCH container 2/2] " Elias Huhsovitz
2026-10-07 13:38 ` [PATCH container/manager 0/2] " Filip Schauer
2026-10-08 10:25 ` Elias Huhsovitz
2026-10-08 13:15 ` Filip Schauer
2026-10-09 9:44 ` Elias Huhsovitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007083726.26067-2-e.huhsovitz@proxmox.com \
--to=e.huhsovitz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.