From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 5E1C11FF0A3 for ; Thu, 01 Oct 2026 14:27:51 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 195852168F; Thu, 01 Oct 2026 14:26:48 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-firewall v2 06/12] fix #5759: firewall: restore from dumped config before network-pre Date: Thu, 1 Oct 2026 14:26:19 +0200 Message-ID: <20261001122625.348730-7-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261001122625.348730-1-a.bied-charreton@proxmox.com> References: <20261001122625.348730-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790857600022 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.201 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WJDDEJDRLYEWE7FB7JBEQYCCJDFELRH2 X-Message-ID-Hash: WJDDEJDRLYEWE7FB7JBEQYCCJDFELRH2 X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: pve-firewall depends on pve-cluster for its config, pve-cluster depends on corosync, which itself depends on network-online. This creates a window at boot where the network is up with no protection. To address this, add a simple oneshot service depending on network-pre [0] that applies the last remembered rules to bridge the gap until the configured firewall daemon takes over. [0] https://systemd.io/NETWORK_ONLINE/ Link: https://bugzilla.proxmox.com/show_bug.cgi?id=5759 Signed-off-by: Arthur Bied-Charreton Reviewed-by: Thomas Ellmenreich Tested-by: Thomas Ellmenreich --- debian/pve-firewall-pre-network.service | 16 ++++++++++++++++ debian/rules | 1 + 2 files changed, 17 insertions(+) create mode 100644 debian/pve-firewall-pre-network.service diff --git a/debian/pve-firewall-pre-network.service b/debian/pve-firewall-pre-network.service new file mode 100644 index 0000000..e1127e4 --- /dev/null +++ b/debian/pve-firewall-pre-network.service @@ -0,0 +1,16 @@ +[Unit] +Description=Proxmox VE Pre-Network iptables Firewall +Wants=network-pre.target +Before=network-pre.target shutdown.target +Conflicts=shutdown.target +DefaultDependencies=no +After=local-fs.target + +[Service] +Type=oneshot +ExecStart=/usr/sbin/pve-firewall restore +RemainAfterExit=true +Environment=PVE_LOG=info + +[Install] +WantedBy=sysinit.target diff --git a/debian/rules b/debian/rules index 9bd53bc..170a90d 100755 --- a/debian/rules +++ b/debian/rules @@ -8,6 +8,7 @@ override_dh_installsystemd: dh_installsystemd --name pvefw-logger pvefw-logger.service + dh_installsystemd --no-start --name pve-firewall-pre-network pve-firewall-pre-network.service dh_installsystemd --name pve-firewall --no-stop-on-upgrade --no-restart-after-upgrade pve-firewall.service override_dh_installinit: -- 2.47.3