From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 909E41FF0A3 for ; Thu, 01 Oct 2026 14:26:47 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C70CD216DB; Thu, 01 Oct 2026 14:26:44 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-firewall v2 02/12] firewall: config: sort OPTIONS when serializing Date: Thu, 1 Oct 2026 14:26:15 +0200 Message-ID: <20261001122625.348730-3-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261001122625.348730-1-a.bied-charreton@proxmox.com> References: <20261001122625.348730-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790857599597 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.279 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7UGXKOIFABMRG6SNBCWRG4RNNFP3S6AI X-Message-ID-Hash: 7UGXKOIFABMRG6SNBCWRG4RNNFP3S6AI X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Until now, firewall config serialization was iterating over the options hash without sorting the keys, making the output non-deterministic. Iterate over the sorted keys instead in format_options. Signed-off-by: Arthur Bied-Charreton Reviewed-by: Thomas Ellmenreich Tested-by: Thomas Ellmenreich --- src/PVE/Firewall.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index da6976e..592e5fe 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -3901,7 +3901,7 @@ my $format_options = sub { my $raw = ''; $raw .= "[OPTIONS]\n\n"; - foreach my $opt (keys %$options) { + foreach my $opt (sort keys $options->%*) { $raw .= "$opt: $options->{$opt}\n"; } $raw .= "\n"; -- 2.47.3