From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 0ADFC1FF0B2 for ; Fri, 25 Sep 2026 14:27:35 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 24A6221794; Fri, 25 Sep 2026 14:26:56 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 6/7] volume chain: blockdev delete: remove superfluous parse_volume_id() call Date: Fri, 25 Sep 2026 14:26:30 +0200 Message-ID: <20260925122646.139215-7-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260925122646.139215-1-f.ebner@proxmox.com> References: <20260925122646.139215-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790339210245 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.504 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2UHF5PYXUCAXEXCB4ZXUR23Y4G4NUQQM X-Message-ID-Hash: 2UHF5PYXUCAXEXCB4ZXUR23Y4G4NUQQM X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The result is not used and volume_snapshot_delete() already dies for invalid volume IDs. Signed-off-by: Fiona Ebner --- src/PVE/QemuServer/VolumeChain.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/PVE/QemuServer/VolumeChain.pm b/src/PVE/QemuServer/VolumeChain.pm index 1572450b..1ad137ed 100644 --- a/src/PVE/QemuServer/VolumeChain.pm +++ b/src/PVE/QemuServer/VolumeChain.pm @@ -72,8 +72,6 @@ sub blockdev_delete { #delete the file (don't use vdisk_free as we don't want to delete all snapshot chain) print "delete old $file_blockdev->{filename}\n"; - my $storage_name = PVE::Storage::parse_volume_id($drive->{file}); - my $volid = $drive->{file}; PVE::Storage::volume_snapshot_delete($storecfg, $volid, $snap, 1); } -- 2.47.3