From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 37D4E1FF0B2 for ; Fri, 25 Sep 2026 14:27:27 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id AD8AA2176F; Fri, 25 Sep 2026 14:26:55 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 5/7] snapshot: use v5.36 and subroutine signatures Date: Fri, 25 Sep 2026 14:26:29 +0200 Message-ID: <20260925122646.139215-6-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260925122646.139215-1-f.ebner@proxmox.com> References: <20260925122646.139215-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790339210146 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.506 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: D2ZRBZDVMICVUPEX4DUYR6NHK6PSZKZO X-Message-ID-Hash: D2ZRBZDVMICVUPEX4DUYR6NHK6PSZKZO X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Fiona Ebner --- src/PVE/QemuServer/Snapshot.pm | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/PVE/QemuServer/Snapshot.pm b/src/PVE/QemuServer/Snapshot.pm index a0d4c239..50f6ac67 100644 --- a/src/PVE/QemuServer/Snapshot.pm +++ b/src/PVE/QemuServer/Snapshot.pm @@ -1,7 +1,6 @@ package PVE::QemuServer::Snapshot; -use strict; -use warnings; +use v5.36; use PVE::Storage; @@ -11,9 +10,7 @@ use PVE::QemuServer::Machine; use PVE::QemuServer::Monitor qw(qmp_cmd); use PVE::QemuServer::VolumeChain; -sub do_snapshots_type { - my ($storecfg, $drive, $deviceid, $running) = @_; - +sub do_snapshots_type($storecfg, $drive, $deviceid, $running) { #we use storage snapshot if vm is not running or if disk is unused; return 'storage' if !$running || !$deviceid; @@ -31,9 +28,7 @@ sub do_snapshots_type { return 'storage'; } -sub qemu_volume_snapshot { - my ($vmid, $deviceid, $storecfg, $drive, $snap) = @_; - +sub qemu_volume_snapshot($vmid, $deviceid, $storecfg, $drive, $snap) { my $volid = $drive->{file}; my $running = PVE::QemuServer::Helpers::vm_running_locally($vmid); @@ -64,9 +59,7 @@ sub qemu_volume_snapshot { } } -sub qemu_volume_snapshot_delete { - my ($vmid, $storecfg, $drive, $snap, $attached_deviceid, $running) = @_; - +sub qemu_volume_snapshot_delete($vmid, $storecfg, $drive, $snap, $attached_deviceid, $running) { my $volid = $drive->{file}; my $do_snapshots_type = do_snapshots_type($storecfg, $drive, $attached_deviceid, $running); -- 2.47.3