From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 96CEB1FF0AF for ; Thu, 24 Sep 2026 18:17:03 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 66647217E7; Thu, 24 Sep 2026 18:15:43 +0200 (CEST) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH manager v6 16/18] fix #4369: ui: dc options: add option for unique VM/CT IDs Date: Thu, 24 Sep 2026 18:15:08 +0200 Message-ID: <20260924161510.847362-17-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260924161510.847362-1-m.koeppl@proxmox.com> References: <20260924161510.847362-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790266513797 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.420 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KBZGLK7OZWLTSVIEKLQZPX2QUQHVO5JL X-Message-ID-Hash: KBZGLK7OZWLTSVIEKLQZPX2QUQHVO5JL X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Severen Redwood Add an additional checkbox to the "Next Free Guest ID" option that allows choosing whether the `/cluster/nextid` API endpoint (and thereby any UI elements that suggest IDs) should avoid suggesting previously used IDs. This option defaults to off to ensure that this change in behaviour is opt in. Also rename the top-level option to "Next Free Guest ID" since it's no longer just the range. Signed-off-by: Michael Köppl --- www/manager6/dc/OptionView.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js index b4291afd3..97f54cda1 100644 --- a/www/manager6/dc/OptionView.js +++ b/www/manager6/dc/OptionView.js @@ -360,7 +360,7 @@ Ext.define('PVE.dc.OptionView', { minValue: 1, maxValue: 64, // arbitrary but generous limit as limits are good }); - me.add_inputpanel_row('next-id', gettext('Next Free Guest ID Range'), { + me.add_inputpanel_row('next-id', gettext('Next Free Guest ID'), { renderer: PVE.Utils.render_as_property_string, url: '/api2/extjs/cluster/options', items: [ @@ -382,6 +382,13 @@ Ext.define('PVE.dc.OptionView', { maxValue: 1000 * 1000 * 1000 - 1, submitValue: true, }, + { + xtype: 'proxmoxcheckbox', + name: 'unique', + fieldLabel: gettext('Unique'), + boxLabel: gettext('Only suggest guest IDs that were never used'), + value: 0, + }, ], }); me.rows['tag-style'] = { -- 2.47.3