[PATCH qemu-server v6 11/18] api, remote migrate: exempt existing VMs from next-id enforcement

["Michael Köppl" <m.koeppl@proxmox.com>]

With 'enforce' set in the next-id datacenter option,
register_used_id() rejects IDs outside the configured range and, with
'unique', IDs that were used before. However, this behavior is only
meant for IDs claimed by new guests.

Destroying a VM and removing the source VM after a remote migration with
--delete both record the ID of a VM that already exists. That ID was
recorded when the VM was created and it may lie outside the configured
range if the range was changed later. Thus, exempt these cases from
enforcement.

Cloning creates a new VM and stays subject to enforcement.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 src/PVE/API2/Qemu.pm   | 2 +-
 src/PVE/QemuMigrate.pm | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index 9cb36e2b..210a0861 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -2860,7 +2860,7 @@ __PACKAGE__->register_method({
         $early_checks->();
 
         # record before destroying anything, so a failure here leaves the VM intact
-        eval { PVE::GuestID::register_used_id($vmid) };
+        eval { PVE::GuestID::register_used_id($vmid, { existing => 1 }) };
         die "unable to destroy VM $vmid - $@" if $@;
 
         my $realcmd = sub {
diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm
index 3f2d9b91..680b5960 100644
--- a/src/PVE/QemuMigrate.pm
+++ b/src/PVE/QemuMigrate.pm
@@ -1905,7 +1905,7 @@ sub phase3_cleanup {
     }
 
     if ($self->{opts}->{remote} && $self->{opts}->{delete}) {
-        eval { PVE::GuestID::register_used_id($vmid) };
+        eval { PVE::GuestID::register_used_id($vmid, { existing => 1 }) };
         warn $@ if $@;
 
         eval { PVE::QemuServer::destroy_vm($self->{storecfg}, $vmid, 1, undef, 0) };
-- 
2.47.3