From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 02FEF1FF0AB for ; Wed, 23 Sep 2026 17:12:49 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 69C68218D1; Wed, 23 Sep 2026 17:10:20 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage v2 37/50] test: parse volname: adapt tests regarding 'import' volume type Date: Wed, 23 Sep 2026 17:05:51 +0200 Message-ID: <20260923150606.531239-38-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260923150606.531239-1-m.carrara@proxmox.com> References: <20260923150606.531239-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790176044279 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.391 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GEPLZ4JXQJGRPMPAXJYKRPDLLQ7PZXBP X-Message-ID-Hash: GEPLZ4JXQJGRPMPAXJYKRPDLLQ7PZXBP X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Give the existing test cases unique 'description' keys and also reorder them. Add additional test cases for qcow2, vmdk and raw files. Signed-off-by: Max R. Carrara --- src/test/parse_volname_test.pm | 29 ++++++++++++++++++++++------- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/src/test/parse_volname_test.pm b/src/test/parse_volname_test.pm index a03ac163..ea07c56b 100644 --- a/src/test/parse_volname_test.pm +++ b/src/test/parse_volname_test.pm @@ -146,27 +146,42 @@ my $tests = [ expected => ['import', 'import.ovf', undef, undef, undef, undef, 'ovf'], }, { - description => "Import, inner file of ova", + description => "Import, qcow2", + volname => 'import/import.qcow2', + expected => ['import', 'import.qcow2', undef, undef, undef, undef, 'qcow2'], + }, + { + description => "Import, vmdk", + volname => 'import/import.vmdk', + expected => ['import', 'import.vmdk', undef, undef, undef, undef, 'vmdk'], + }, + { + description => "Import, raw", + volname => 'import/import.raw', + expected => ['import', 'import.raw', undef, undef, undef, undef, 'raw'], + }, + { + description => "Import, inner file of ova (qcow2)", volname => 'import/import.ova/disk.qcow2', expected => ['import', 'import.ova/disk.qcow2', undef, undef, undef, undef, 'ova+qcow2'], }, { - description => "Import, inner file of ova", + description => "Import, inner file of ova (vmdk)", volname => 'import/import.ova/disk.vmdk', expected => ['import', 'import.ova/disk.vmdk', undef, undef, undef, undef, 'ova+vmdk'], }, + { + description => "Import, inner file of ova (raw)", + volname => 'import/import.ova/disk.raw', + expected => ['import', 'import.ova/disk.raw', undef, undef, undef, undef, 'ova+raw'], + }, { description => "Import, inner file of ova with whitespace in name", volname => 'import/import.ova/OS disk.vmdk', expected => ['import', 'import.ova/OS disk.vmdk', undef, undef, undef, undef, 'ova+vmdk'], }, - { - description => "Import, inner file of ova", - volname => 'import/import.ova/disk.raw', - expected => ['import', 'import.ova/disk.raw', undef, undef, undef, undef, 'ova+raw'], - }, # # failed matches # -- 2.47.3