From: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
To: pbs-devel@lists.proxmox.com
Cc: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
Subject: [PATCH proxmox-backup 2/2] fix #4646: backup writer: base debug flag on log level
Date: Wed, 23 Sep 2026 12:27:59 +0200 [thread overview]
Message-ID: <20260923102759.139819-3-t.ellmenreich@proxmox.com> (raw)
In-Reply-To: <20260923102759.139819-1-t.ellmenreich@proxmox.com>
Before, the debug flag had to be set manually for each instance of
BackupWriterOptions. However, with the 'new' constructor, the parameter has
been removed and the flag is now derived from the verbosity of the current log
level.
Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=4646
Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
---
examples/upload-speed.rs | 1 -
pbs-client/src/backup_writer.rs | 3 +--
proxmox-backup-client/src/benchmark.rs | 1 -
proxmox-backup-client/src/main.rs | 1 -
src/server/push.rs | 1 -
5 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/examples/upload-speed.rs b/examples/upload-speed.rs
index a0b742854..851eee1e6 100644
--- a/examples/upload-speed.rs
+++ b/examples/upload-speed.rs
@@ -24,7 +24,6 @@ async fn upload_speed() -> Result<f64, Error> {
&BackupNamespace::root(),
&(BackupType::Host, "speedtest".to_string(), backup_time).into(),
None,
- false,
true,
false,
),
diff --git a/pbs-client/src/backup_writer.rs b/pbs-client/src/backup_writer.rs
index 7c3cb21b7..7ae12295d 100644
--- a/pbs-client/src/backup_writer.rs
+++ b/pbs-client/src/backup_writer.rs
@@ -106,7 +106,6 @@ impl<'a> BackupWriterOptions<'a> {
ns: &'a BackupNamespace,
backup: &'a BackupDir,
crypt_config: Option<Arc<CryptConfig>>,
- debug: bool,
benchmark: bool,
no_cache: bool,
) -> Self {
@@ -115,7 +114,7 @@ impl<'a> BackupWriterOptions<'a> {
ns,
backup,
crypt_config,
- debug,
+ debug: proxmox_log::enabled!(Level::DEBUG),
benchmark,
no_cache,
}
diff --git a/proxmox-backup-client/src/benchmark.rs b/proxmox-backup-client/src/benchmark.rs
index af9113ecb..924f825e8 100644
--- a/proxmox-backup-client/src/benchmark.rs
+++ b/proxmox-backup-client/src/benchmark.rs
@@ -243,7 +243,6 @@ async fn test_upload_speed(
&BackupNamespace::root(),
&(BackupType::Host, "benchmark".to_string(), backup_time).into(),
crypt_config.clone(),
- false,
true,
no_cache,
),
diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs
index 3aaaac39e..0067d87eb 100644
--- a/proxmox-backup-client/src/main.rs
+++ b/proxmox-backup-client/src/main.rs
@@ -1051,7 +1051,6 @@ async fn create_backup(
&backup_ns,
&snapshot,
crypt_config.clone(),
- true,
false,
no_cache,
),
diff --git a/src/server/push.rs b/src/server/push.rs
index 665c77a8d..5067d8033 100644
--- a/src/server/push.rs
+++ b/src/server/push.rs
@@ -1141,7 +1141,6 @@ pub(crate) async fn push_snapshot(
.map(|(_id, conf)| Arc::clone(conf)),
false,
false,
- false,
),
)
.await
--
2.47.3
prev parent reply other threads:[~2026-09-23 10:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 10:27 [RFC proxmox-backup 0/2] backup log: reduce logging during backup Thomas Ellmenreich
2026-09-23 10:27 ` [PATCH proxmox-backup 1/2] backup writer: add constructor for BackupWriterOptions Thomas Ellmenreich
2026-09-23 10:27 ` Thomas Ellmenreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923102759.139819-3-t.ellmenreich@proxmox.com \
--to=t.ellmenreich@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.