From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 8C10D1FF0AB for ; Wed, 23 Sep 2026 09:06:03 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3318821633; Wed, 23 Sep 2026 09:05:31 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v5 2/9] pci: mdev preparation: always generate local uuid first Date: Wed, 23 Sep 2026 09:04:55 +0200 Message-ID: <20260923070522.434715-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260923070522.434715-1-d.csapak@proxmox.com> References: <20260923070522.434715-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.451 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IONS54CUD36YIUJKRFAW4I4HKAVAES5Q X-Message-ID-Hash: IONS54CUD36YIUJKRFAW4I4HKAVAES5Q X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We still prefer the uuid from the smbios config, but this makes the pci preparation code independent of `parse_smbios1` and we can later move it out. Signed-off-by: Dominik Csapak Reviewed-by: Elias Huhsovitz Tested-by: Elias Huhsovitz Reviewed-by: Jakob Klocker Tested-by: Jakob Klocker --- src/PVE/QemuServer.pm | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 0ed75cd7..2f9eae6c 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -5680,14 +5680,17 @@ sub vm_start_nolock { # nvidia grid needs the uuid of the mdev as qemu parameter if (!defined($uuid) && $chosen_mdev->{vendor} =~ m/^(0x)?10de$/) { - if (defined($conf->{smbios1})) { - my $smbios_conf = parse_smbios1($conf->{smbios1}); - $uuid = $smbios_conf->{uuid} if defined($smbios_conf->{uuid}); - } - $uuid = PVE::QemuServer::PCI::Mdev::generate_mdev_uuid($vmid, $index) - if !defined($uuid); + $uuid = PVE::QemuServer::PCI::Mdev::generate_mdev_uuid($vmid, $index); } } + + # uuid for nvidia vgpu + # prefer the smbios1 uuid if we have and need it + if (defined($uuid) && defined($conf->{smbios1})) { + my $smbios_conf = parse_smbios1($conf->{smbios1}); + $uuid = $smbios_conf->{uuid} if defined($smbios_conf->{uuid}); + } + push @$cmd, '-uuid', $uuid if defined($uuid); }; if (my $err = $@) { -- 2.47.3