From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id BCAB11FF09C for ; Mon, 21 Sep 2026 17:54:28 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3B717214E9; Mon, 21 Sep 2026 17:54:25 +0200 (CEST) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH many v5 0/7] add option to prevent suggesting previously used VMIDs Date: Mon, 21 Sep 2026 17:54:03 +0200 Message-ID: <20260921155410.938337-1-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790006058930 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.586 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PMPYZFJOCY7OHNIJFKBWTVCWKRBHCZBM X-Message-ID-Hash: PMPYZFJOCY7OHNIJFKBWTVCWKRBHCZBM X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This is based on the original series [0] by Severen Redwood and Daniel Krambrock. It it rebased on the latest master branches and incorporates the feedback from v4. I kept the trailers from the original series where I made only minimal changes, but added markers (MK: ...) in those cases. For bigger changes, I changed the `Co-authored-by` and `Signed-off-by` trailers to `Signed-off-by`. I removed Aaron's T-b and R-b trailers since it's been a long time and the trailers might be misleading considering the series has changed in some of its implementation details overall. Changes since v4: - File in pmxcfs has been renamed to used-guest-ids to make it a bit more general (both VMs and CTs) while still making clear which IDs are meant. - Moved the `UsedVmidList` module from pve-manager to pve-guest-common and renamed it `UsedGuestIDs`. Also renamed some of the functions there for more consistent naming. - Implemented `write_id_list` more closely aligned with Fabian's feedback. - Also record used VMIDs when creating, cloning, destroying guests as well as incoming remote migrations. (Thanks, @Fiona, for the off-list input and feedback!) - Moved the `add_id` calls for recording used IDs to before anything is persisted during any of the above actions. - Rephrased some commit messages. [0] https://lore.proxmox.com/pve-devel/mailman.62.1731030290.372.pve-devel@lists.proxmox.com/ pve-cluster: Severen Redwood (2): cluster files: add used-guest-ids datacenter config: add unique-next-id to schema src/PVE/Cluster.pm | 1 + src/PVE/DataCenterConfig.pm | 6 ++++++ src/pmxcfs/status.c | 1 + 3 files changed, 8 insertions(+) pve-guest-common: Michael Köppl (1): add module to track previously used guest IDs src/Makefile | 1 + src/PVE/UsedGuestIDs.pm | 93 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 94 insertions(+) create mode 100644 src/PVE/UsedGuestIDs.pm qemu-server: Michael Köppl (1): api: record VM ID as used on creation, cloning, and destruction src/PVE/API2/Qemu.pm | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) pve-container: Michael Köppl (1): api: record CT ID as used on creation, cloning, and destruction src/PVE/API2/LXC.pm | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) pve-manager: Michael Köppl (1): close #4369: api: optionally only suggest unique IDs Severen Redwood (1): close #4369: ui: add datacenter option for unique VM/CT IDs PVE/API2/Cluster.pm | 9 ++++++++- www/manager6/dc/OptionView.js | 4 ++++ 2 files changed, 12 insertions(+), 1 deletion(-) Summary over all repositories: 9 files changed, 150 insertions(+), 1 deletions(-) -- Generated by murpp 0.12.1