From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 741661FF09C for ; Mon, 21 Sep 2026 15:26:17 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5397D214D0; Mon, 21 Sep 2026 15:26:15 +0200 (CEST) From: Samuel Rufinatscha To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 1/1] pve8to9: warn about an unmounted ESP Date: Mon, 21 Sep 2026 15:26:04 +0200 Message-ID: <20260921132604.303143-2-s.rufinatscha@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260921132604.303143-1-s.rufinatscha@proxmox.com> References: <20260921132604.303143-1-s.rufinatscha@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789997169695 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.308 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DEOA3YNMVXRU4PIS42WQ2UXBVL57VFS6 X-Message-ID-Hash: DEOA3YNMVXRU4PIS42WQ2UXBVL57VFS6 X-MailFrom: s.rufinatscha@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: A UEFI system may fail to boot after upgrading from PVE 8 to PVE 9 if its EFI System Partition (ESP) was not mounted at /boot/efi during the GRUB update. Warn if /boot/efi is not mounted on a UEFI system. Ask the user to mount it before upgrading and to make sure it mounts at boot. Skip systems managed by proxmox-boot-tool, which mounts the ESPs itself. Link: https://bugzilla.proxmox.com/show_bug.cgi?id=7958 Signed-off-by: Samuel Rufinatscha --- PVE/CLI/pve8to9.pm | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm index cf0f2f69..0c15cda9 100644 --- a/PVE/CLI/pve8to9.pm +++ b/PVE/CLI/pve8to9.pm @@ -21,6 +21,7 @@ use PVE::Jobs; use PVE::JSONSchema; use PVE::Network; use PVE::NodeConfig; +use PVE::ProcFSTools; use PVE::RPCEnvironment; use PVE::Storage; use PVE::Storage::Plugin; @@ -1624,6 +1625,15 @@ sub check_bootloader { } } } else { + if (!PVE::ProcFSTools::is_mounted('/boot/efi')) { + log_warn( + "System booted in UEFI mode but the EFI System Partition (ESP) is not mounted at" + . " /boot/efi. Mount it at /boot/efi before upgrading and ensure it mounts" + . " automatically at boot (e.g. via /etc/fstab), otherwise GRUB updates may leave" + . " the system unbootable." + ); + $boot_ok = 0; + } if (!-f "/usr/share/doc/grub-efi-amd64/changelog.Debian.gz") { log_warn("System booted in uefi mode but grub-efi-amd64 meta-package not installed," . " new grub versions will not be installed to /boot/efi! Install grub-efi-amd64." -- 2.47.3