From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 1FB161FF09C for ; Mon, 21 Sep 2026 10:57:26 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7D3B021590; Mon, 21 Sep 2026 10:57:16 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH-SERIES docs/storage v2 0/3] close #7204: document and check that thin pools have zeroing enabled Date: Mon, 21 Sep 2026 10:56:55 +0200 Message-ID: <20260921085707.70272-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789981030412 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.562 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: X7UWSW5KKYJUTPLYLANFNEIHTKN4IZRQ X-Message-ID-Hash: X7UWSW5KKYJUTPLYLANFNEIHTKN4IZRQ X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Changes in v2: * Suggest more generic command for checking whether zeroing is enabled in docs. * Use full '--zero=y' in suggested command for activating zeroing. * Expand comment about a potential future configuration option to support thin pools without 'zero'. There were a bunch of new reports in the last week. Not sure why, maybe a bogus tutorial out there or something along those lines. Thin pools with zeroing during allocation turned off are currently not supported for VM images. Using such a pool may lead to data corruption for various operations like drive mirror. Document this and add a check in the storage plugin upon storage activation. In the future, a dedicated storage configuration option could be introduced that can be checked by volume_has_feature() and enforced upon storage activation. docs: Fiona Ebner (1): close #7204: storage: lvm thin: document that thin pools must have zeroing enabled pve-storage-lvmthin.adoc | 6 ++++++ 1 file changed, 6 insertions(+) storage: Fiona Ebner (2): lvm plugin: list volumes: also query 'zero' property close #7204: lvm thin plugin: die if thin pool does not have zeroing configured src/PVE/Storage/LVMPlugin.pm | 6 ++++-- src/PVE/Storage/LvmThinPlugin.pm | 19 ++++++++++++++++++- 2 files changed, 22 insertions(+), 3 deletions(-) Summary over all repositories: 3 files changed, 28 insertions(+), 3 deletions(-) -- Generated by git-murpp 0.5.0