all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup-qemu v2 3/8] commands: fix clippy error for reimplementing Result::ok()
Date: Wed, 16 Sep 2026 16:48:38 +0200	[thread overview]
Message-ID: <20260916144843.567913-4-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260916144843.567913-1-c.ebner@proxmox.com>

Call Result::ok() on the index download result, avoiding
reimplementation thereof.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/commands.rs | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/commands.rs b/src/commands.rs
index 95e7c17..d482fd5 100644
--- a/src/commands.rs
+++ b/src/commands.rs
@@ -195,14 +195,11 @@ pub(crate) async fn register_image(
 
     let index = match manifest {
         Some(manifest) => {
-            match client
+            // not having a previous index is not fatal, so ignore errors
+            client
                 .download_previous_fixed_index(&archive_name, &manifest, Arc::clone(&known_chunks))
                 .await
-            {
-                Ok(index) => Some(index),
-                // not having a previous index is not fatal, so ignore errors
-                Err(_) => None,
-            }
+                .ok()
         }
         None => None,
     };
-- 
2.47.3





  parent reply	other threads:[~2026-09-16 14:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 14:48 [PATCH many v2 0/8] fix #7530: Implement download bandwidth and restore limits for pbs-restore Christian Ebner
2026-09-16 14:48 ` [PATCH proxmox v2 1/8] pbs-api-types: expose ClientRateLimitConfig fields as pub Christian Ebner
2026-09-16 14:48 ` [PATCH proxmox-backup-qemu v2 2/8] commands/restore: fix useless borrow clippy warnings for archive names Christian Ebner
2026-09-16 14:48 ` Christian Ebner [this message]
2026-09-16 14:48 ` [PATCH proxmox-backup-qemu v2 4/8] commands: extend stricter type checks for guest config " Christian Ebner
2026-09-16 14:48 ` [PATCH proxmox-backup-qemu v2 5/8] restore: implement `bw-limit` parameter imposing download rate limits Christian Ebner
2026-09-16 14:48 ` [PATCH proxmox-backup-qemu v2 6/8] restore: implement `rate-limit` imposing chunk data stream limits Christian Ebner
2026-09-16 14:48 ` [PATCH pve-qemu v2 7/8] fix #7530: pbs-restore: expose optional rate limit parameters Christian Ebner
2026-09-16 14:48 ` [PATCH qemu-server v2 8/8] pbs-restore: set restore bandwidth limit for volumes Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260916144843.567913-4-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal