From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 9FA3F1FF0A7 for ; Wed, 16 Sep 2026 11:07:55 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 81A602146F; Wed, 16 Sep 2026 11:07:51 +0200 (CEST) From: Jonas Theisen To: pve-devel@lists.proxmox.com Subject: [PATCH manager 2/5] ui: align VM context menu to permissions Date: Wed, 16 Sep 2026 11:06:56 +0200 Message-ID: <20260916090715.72307-3-j.theisen@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260916090715.72307-1-j.theisen@proxmox.com> References: <20260916090715.72307-1-j.theisen@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789549654816 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.271 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KJKON5IQX7VLROSCPNW6LGOQJET5DBUN X-Message-ID-Hash: KJKON5IQX7VLROSCPNW6LGOQJET5DBUN X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This patch better aligns the VM context / command menu to the users permissions by hiding commands which are not available. This is similar to what is already being done on the VM status page. Signed-off-by: Jonas Theisen --- www/manager6/qemu/CmdMenu.js | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/www/manager6/qemu/CmdMenu.js b/www/manager6/qemu/CmdMenu.js index df6045bf..54ab86b1 100644 --- a/www/manager6/qemu/CmdMenu.js +++ b/www/manager6/qemu/CmdMenu.js @@ -60,41 +60,43 @@ Ext.define('PVE.qemu.CmdMenu', { { text: gettext('Start'), iconCls: 'fa fa-fw fa-play', - hidden: running || suspended, - disabled: running || suspended, + hidden: running || suspended || !caps.vms['VM.PowerMgmt'], + disabled: running || suspended || !caps.vms['VM.PowerMgmt'], handler: () => vm_command('start'), }, { text: gettext('Pause'), iconCls: 'fa fa-fw fa-pause', - hidden: stopped || suspended, - disabled: stopped || suspended, + hidden: stopped || suspended || !caps.vms['VM.PowerMgmt'], + disabled: stopped || suspended || !caps.vms['VM.PowerMgmt'], handler: () => confirmedVMCommand('suspend', undefined, 'qmpause'), }, { text: gettext('Hibernate'), iconCls: 'fa fa-fw fa-download', - hidden: stopped || suspended, - disabled: stopped || suspended, + hidden: stopped || suspended || !caps.vms['VM.PowerMgmt'], + disabled: stopped || suspended || !caps.vms['VM.PowerMgmt'], tooltip: gettext('Suspend to disk'), handler: () => confirmedVMCommand('suspend', { todisk: 1 }), }, { text: gettext('Resume'), iconCls: 'fa fa-fw fa-play', - hidden: !suspended, + hidden: !suspended || !caps.vms['VM.PowerMgmt'], handler: () => vm_command('resume'), }, { text: gettext('Shutdown'), iconCls: 'fa fa-fw fa-power-off', - disabled: stopped || suspended, + disabled: stopped || suspended || !caps.vms['VM.PowerMgmt'], + hidden: !caps.vms['VM.PowerMgmt'], handler: () => confirmedVMCommand('shutdown'), }, { text: gettext('Stop'), iconCls: 'fa fa-fw fa-stop', - disabled: stopped, + disabled: stopped || !caps.vms['VM.PowerMgmt'], + hidden: !caps.vms['VM.PowerMgmt'], tooltip: Ext.String.format(gettext('Stop {0} immediately'), 'VM'), handler: () => { Ext.create('PVE.GuestStop', { @@ -107,14 +109,16 @@ Ext.define('PVE.qemu.CmdMenu', { { text: gettext('Reboot'), iconCls: 'fa fa-fw fa-refresh', - disabled: stopped, + disabled: stopped || !(caps.vms['VM.Reboot'] || caps.vms['VM.PowerMgmt']), + hidden: !(caps.vms['VM.Reboot'] || caps.vms['VM.PowerMgmt']), tooltip: Ext.String.format(gettext('Reboot {0}'), 'VM'), handler: () => confirmedVMCommand('reboot'), }, { text: gettext('Reset'), iconCls: 'fa fa-fw fa-bolt', - disabled: stopped, + disabled: stopped || !(caps.vms['VM.Reboot'] || caps.vms['VM.PowerMgmt']), + hidden: !(caps.vms['VM.Reboot'] || caps.vms['VM.PowerMgmt']), tooltip: Ext.String.format(gettext('Reset {0}'), 'VM'), handler: () => confirmedVMCommand('reset'), }, -- 2.47.3