From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 9C71A1FF0AE for ; Tue, 15 Sep 2026 16:33:10 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 63EE721623; Tue, 15 Sep 2026 16:33:04 +0200 (CEST) From: Nicolas Frey To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 3/3] partially fix #7801: vm start: warn about problematic VirtIO ISOs Date: Tue, 15 Sep 2026 16:32:37 +0200 Message-ID: <20260915143237.1033142-4-n.frey@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260915143237.1033142-1-n.frey@proxmox.com> References: <20260915143237.1033142-1-n.frey@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.909 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: JMF4DJG3IKBLOGGPAFLQJB23Z7SBDZZP X-Message-ID-Hash: JMF4DJG3IKBLOGGPAFLQJB23Z7SBDZZP X-MailFrom: nfrey@miso.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: An ISO can end up in a CD-ROM drive without passing through the configuration API, e.g. by restoring a backup or by editing the configuration file directly. checking on start covers these cases too and puts the warning in the task log right next to the boot that might be affected by the known issue. Signed-off-by: Nicolas Frey --- src/PVE/QemuServer.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 759f7db2..0ed75cd7 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -5627,6 +5627,8 @@ sub vm_start_nolock { check_efi_vars($storecfg, $vmid, $conf) if $conf->{bios} && $conf->{bios} eq 'ovmf'; + PVE::QemuServer::Drive::warn_about_virtio_win_issues_in_config($conf); + # Note that for certain cases like templates, the configuration is minimized, so need to ensure # the rest of the function here uses the same configuration that was used to build the command ($cmd, $spice_port, my $pci_devices, $conf) = config_to_command( -- 2.47.3