all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Jonas Theisen <j.theisen@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v2 2/2] fix #8031: write APT proxy config on http_proxy change
Date: Mon, 14 Sep 2026 17:24:12 +0200	[thread overview]
Message-ID: <20260914152423.410631-3-j.theisen@proxmox.com> (raw)
In-Reply-To: <20260914152423.410631-1-j.theisen@proxmox.com>

Writes the necessary file for APT if the http_proxy variable
on the datacenter level is changed.

This reuses the same function from the APT API for a regular
database update.

Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
 PVE/API2/Cluster.pm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm
index 4e5efbfd..8529c026 100644
--- a/PVE/API2/Cluster.pm
+++ b/PVE/API2/Cluster.pm
@@ -36,6 +36,7 @@ use PVE::API2::ClusterConfig;
 use PVE::API2::Firewall::Cluster;
 use PVE::API2::HAConfig;
 use PVE::API2::ReplicationConfig;
+use PVE::API2::APT;
 
 my $have_sdn;
 eval {
@@ -842,7 +843,11 @@ __PACKAGE__->register_method({
     code => sub {
         my ($param) = @_;
 
+        my $http_proxy_change = 0;
+
         my $delete = extract_param($param, 'delete');
+        $http_proxy_change = 1
+            if ((defined($param->{http_proxy})) || (defined($delete) && $delete =~ m/\bhttp_proxy\b/ ));
 
         cfs_lock_file(
             'datacenter.cfg',
@@ -859,6 +864,10 @@ __PACKAGE__->register_method({
         );
         die $@ if $@;
 
+        if ($http_proxy_change) {
+            PVE::API2::APT::update_apt_proxy_config();
+        }
+
         return undef;
     },
 });
-- 
2.47.3





  parent reply	other threads:[~2026-09-14 15:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 15:24 [PATCH pve-manager v2 0/2] fix #8031: Write APT proxy config on http_proxy change Jonas Theisen
2026-09-14 15:24 ` [PATCH pve-manager v2 1/2] fix #8031: factor out APT proxy write from update_database call Jonas Theisen
2026-09-14 15:24 ` Jonas Theisen [this message]
2026-09-15  8:03   ` [PATCH pve-manager v2 2/2] fix #8031: write APT proxy config on http_proxy change Maximiliano Sandoval
2026-09-15  9:18 ` [PATCH pve-manager v2 0/2] fix #8031: Write " Jonas Theisen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260914152423.410631-3-j.theisen@proxmox.com \
    --to=j.theisen@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal