From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id EBC051FF09B for ; Mon, 14 Sep 2026 13:49:29 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id ABDD2215AE; Mon, 14 Sep 2026 13:49:26 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH ifupdown2] d/patches: don't fail vxlan syntax check on missing local tunnelip Date: Mon, 14 Sep 2026 13:49:02 +0200 Message-ID: <20260914114918.144970-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789386548963 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.300 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CZE6HGF435IV7IWI5GWFB32JGTYMEGAH X-Message-ID-Hash: CZE6HGF435IV7IWI5GWFB32JGTYMEGAH X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Don't fail the syntax check when no vxlan-local-tunnelip is configured. This is fine, the local tunnelip can be retrieved from somewhere else. Check the patch description for more info. We don't usually run `ifreload -s`, so the syntax check won't be run on a normal apply. Motivation: https://lore.proxmox.com/pve-devel/aqEkLo5GMnrhZoJF@luna.proxmox.com/ Signed-off-by: Gabriel Goller --- ...-t-fail-syntax-check-on-missing-vxla.patch | 39 +++++++++++++++++++ debian/patches/series | 1 + 2 files changed, 40 insertions(+) create mode 100644 debian/patches/pve/0016-addons-vxlan-don-t-fail-syntax-check-on-missing-vxla.patch diff --git a/debian/patches/pve/0016-addons-vxlan-don-t-fail-syntax-check-on-missing-vxla.patch b/debian/patches/pve/0016-addons-vxlan-don-t-fail-syntax-check-on-missing-vxla.patch new file mode 100644 index 000000000000..9fab80d662bb --- /dev/null +++ b/debian/patches/pve/0016-addons-vxlan-don-t-fail-syntax-check-on-missing-vxla.patch @@ -0,0 +1,39 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Gabriel Goller +Date: Sun, 14 Sep 2026 12:00:00 +0200 +Subject: [PATCH] addons: vxlan: don't fail syntax check on missing + vxlan-local-tunnelip + +vxlan-local-tunnelip is declared optional, both in the module's attribute +description and in the generated man page. Without it the kernel picks +the source address from the route to the remote endpoint, which is what +we want for setups that use vxlan-physdev or a multicast group. The +check is a Cumulus-ism that assumes every vxlan is anchored on a loopback +address. + +The warning also made this whole check return False, so `ifup --syntax-check` +failed for a perfectly valid configuration. + +The early return also skipped check_and_raise_svd_tvd_errors(), so a real +single-vxlan/traditional-vxlan mixing error was suppressed until the interface +was actually brought up. Removing the block restores that check for devices +without a local tunnel ip. + +Signed-off-by: Gabriel Goller +--- + ifupdown2/addons/vxlan.py | 4 ---- + 1 file changed, 4 deletions(-) + +--- a/ifupdown2/addons/vxlan.py ++++ b/ifupdown2/addons/vxlan.py +@@ -191,10 +191,6 @@ + + def syntax_check(self, ifaceobj, ifaceobj_getfunc): + if self._is_vxlan_device(ifaceobj): +- if not ifaceobj.get_attr_value_first('vxlan-local-tunnelip') and not self._vxlan_local_tunnelip: +- self.logger.warning('%s: missing vxlan-local-tunnelip' % ifaceobj.name) +- return False +- + self.check_and_raise_svd_tvd_errors(ifaceobj) + + return self.syntax_check_localip_anycastip_equal( diff --git a/debian/patches/series b/debian/patches/series index 2865533271c9..0eec1531762a 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -16,3 +16,4 @@ upstream/0001-use-raw-strings-for-regex-to-fix-backslash-interpret.patch upstream/0002-vxlan-add-support-for-IPv6-vxlan-local-tunnelip.patch pve/0014-nlmanager-read-ipv6-devconf-disable_ipv6-attribute-t.patch pve/0015-revert-addons-bond-warn-if-sub-interface-is-detected-on-bond-slave.patch +pve/0016-addons-vxlan-don-t-fail-syntax-check-on-missing-vxla.patch -- 2.47.3