all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Kaiyang Wu <wukaiyang2003@gmail.com>
To: pve-devel@lists.proxmox.com
Cc: Kaiyang Wu <wukaiyang@loongfans.cn>
Subject: [PATCH ha-manager 5/5] lrm: stop and restart panicked VMs to keep the "started" state
Date: Mon, 14 Sep 2026 17:20:12 +0800	[thread overview]
Message-ID: <20260914092015.125780-6-wukaiyang@loongfans.cn> (raw)
In-Reply-To: <20260914092015.125780-1-wukaiyang@loongfans.cn>

When a VM panics, 'check_running()' returns -1 to indicate the panicked
state. Stop the service first since panicked VMs are still running, then
restart the service to keep the "started" state.

Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
---
 src/PVE/HA/LRM.pm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm
index 72e37e6..8fa1ff6 100644
--- a/src/PVE/HA/LRM.pm
+++ b/src/PVE/HA/LRM.pm
@@ -982,7 +982,14 @@ sub exec_resource_agent {
 
     if ($cmd eq 'started') {
 
-        return SUCCESS if $running;
+        return SUCCESS if $running == 1; # running normally
+
+        # stop the panicked service before restarting it
+        if ($running == -1) {
+            $haenv->log("info", "stopping panicked service $sid");
+
+            $plugin->shutdown($haenv, $id, 0);
+        }
 
         $haenv->log("info", "starting service $sid");
 
-- 
2.55.0




      parent reply	other threads:[~2026-09-14  9:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14  9:20 [PATCH qemu-server/docs/manager/ha-manager 0/5] add pvpanic device support Kaiyang Wu
2026-09-14  9:20 ` [PATCH qemu-server 1/5] qemuserver: add pvpanic device Kaiyang Wu
2026-09-14  9:20 ` [PATCH docs 2/5] qm: add document section for the " Kaiyang Wu
2026-09-14  9:20 ` [PATCH manager 3/5] ui: qemu: add pvpanic device support Kaiyang Wu
2026-09-14  9:20 ` [PATCH ha-manager 4/5] vm resource: return running status -1 for panicked VMs Kaiyang Wu
2026-09-14  9:20 ` Kaiyang Wu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260914092015.125780-6-wukaiyang@loongfans.cn \
    --to=wukaiyang2003@gmail.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=wukaiyang@loongfans.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal