[PATCH proxmox-backup 2/5] report: do not include remote passwords

[Erik Fastermann <e.fastermann@proxmox.com>]

remote.cfg stores the password or API token of the remote user as a
base64 string, which is trivially reversible. As reports are commonly
shared with third parties, for example in public forum threads, list
the remotes through the API instead, which returns every property but
the password. Proxmox Datacenter Manager handles its own remote
configuration the same way.

The JSON output format is used for two reasons: the text table only
covers a subset of the configured properties, and the report runs all
commands with PROXMOX_OUTPUT_NO_BORDER set, which also suppresses the
table header and thus leaves the columns unlabeled. The latter could
alternatively be solved with a custom text formatter, as done for the
remote listing in Proxmox Datacenter Manager.

Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
---
 src/server/report.rs | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/server/report.rs b/src/server/report.rs
index d293aa6dd..c22141810 100644
--- a/src/server/report.rs
+++ b/src/server/report.rs
@@ -10,7 +10,6 @@ fn project_files() -> Vec<FileGroup> {
                 "/etc/proxmox-backup/acl.cfg",
             ],
         ),
-        ("Remotes", vec!["/etc/proxmox-backup/remote.cfg"]),
         (
             "Jobs",
             vec![
@@ -41,6 +40,10 @@ fn project_commands() -> Vec<StaticArgsCommandSpec> {
         ("date", vec!["-R"]),
         ("proxmox-backup-manager", vec!["versions", "--verbose"]),
         ("proxmox-backup-manager", vec!["subscription", "get"]),
+        (
+            "proxmox-backup-manager",
+            vec!["remote", "list", "--output-format", "json-pretty"],
+        ),
         ("proxmox-backup-manager", vec!["ldap", "list"]),
         ("proxmox-backup-manager", vec!["openid", "list"]),
     ]
-- 
2.47.3