From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 44F251FF0AA for ; Mon, 07 Sep 2026 18:04:46 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 978CC212F2; Mon, 07 Sep 2026 18:04:45 +0200 (CEST) From: Samuel Rufinatscha To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox{,-backup} 0/2] fix #7948: acme: disable connection pooling for certificate renewal Date: Mon, 7 Sep 2026 18:04:32 +0200 Message-ID: <20260907160434.262678-1-s.rufinatscha@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788797073735 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.667 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: W35YTBRYN5F5OEXZBIQ4WNILHEI4E3BE X-Message-ID-Hash: W35YTBRYN5F5OEXZBIQ4WNILHEI4E3BE X-MailFrom: s.rufinatscha@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ACME certificate renewal can fail [0] after an order has been finalized if the CA closes the HTTP/1.1 connection during the polling delay. Reusing that stale connection then causes the task to fail with: "TASK ERROR: client error (SendRequest)" Makes the maximum number of idle connections configurable in the shared HTTP client and disables connection pooling for ACME requests. Testing: The issue was reproduced using Pebble and a proxy which drops a reused connection after order finalization. The unpatched PBS build failed with SendRequest, while the patched build opened a new connection for the subsequent poll and completed certificate issuance successfully. Notes for the maintainer: * adds a public field to HttpOptions * both PBS and PDM require the updated crates [0] https://bugzilla.proxmox.com/show_bug.cgi?id=7948 proxmox: Samuel Rufinatscha (1): fix #7948: acme: disable HTTP connection pooling proxmox-acme/src/async_client.rs | 1 + proxmox-http/src/client/simple.rs | 9 +++++++-- proxmox-http/src/http_options.rs | 3 +++ 3 files changed, 11 insertions(+), 2 deletions(-) proxmox-backup: Samuel Rufinatscha (1): http: adapt to new pool_max_idle_per_host option src/api2/node/subscription.rs | 1 + src/tools/mod.rs | 1 + 2 files changed, 2 insertions(+) Summary over all repositories: 5 files changed, 13 insertions(+), 2 deletions(-) -- Generated by git-murpp 0.8.1