From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 2AFBE1FF0A5 for ; Fri, 04 Sep 2026 11:39:20 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6CB3D21642; Fri, 04 Sep 2026 11:38:47 +0200 (CEST) From: Hannes Laimer To: pve-devel@lists.proxmox.com Subject: [PATCH pve-network 05/12] sdn: subnets: add dhcp-lease-time property Date: Fri, 4 Sep 2026 11:38:28 +0200 Message-ID: <20260904093835.1050030-6-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260904093835.1050030-1-h.laimer@proxmox.com> References: <20260904093835.1050030-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788514719549 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.628 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: B54F2NEBIQ6P2EHBLRTH3KRBVU22GSJ3 X-Message-ID-Hash: B54F2NEBIQ6P2EHBLRTH3KRBVU22GSJ3 X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Lease time is the convergence knob for mapping edits: a client picks up a changed record at the latest one lease after the edit. Make it configurable per subnet for dhcp backends that honor it. Signed-off-by: Hannes Laimer --- src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 3 ++- src/PVE/Network/SDN/SubnetPlugin.pm | 9 +++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm b/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm index 4677330..861a3ed 100644 --- a/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm +++ b/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm @@ -185,7 +185,8 @@ sub configure_subnet { $mask = join('.', unpack("C4", pack("N", $mask))); } - push @{$config}, "dhcp-range=set:$tag,$network,static,$mask,infinite"; + my $lease = $subnet_config->{'dhcp-lease-time'} // 'infinite'; + push @{$config}, "dhcp-range=set:$tag,$network,static,$mask,$lease"; my $option_string; if (ip_is_ipv6($subnet_config->{network})) { diff --git a/src/PVE/Network/SDN/SubnetPlugin.pm b/src/PVE/Network/SDN/SubnetPlugin.pm index e2a0e50..c362c78 100644 --- a/src/PVE/Network/SDN/SubnetPlugin.pm +++ b/src/PVE/Network/SDN/SubnetPlugin.pm @@ -177,6 +177,14 @@ sub properties { description => 'IP address for the DNS server', optional => 1, }, + 'dhcp-lease-time' => { + type => 'integer', + minimum => 60, + description => + 'Lease time in seconds for DHCP answers. Without it dnsmasq hands out' + . ' infinite leases and the ebpf responder ten minutes.', + optional => 1, + }, }; } @@ -189,6 +197,7 @@ sub options { dnszoneprefix => { optional => 1 }, 'dhcp-range' => { optional => 1 }, 'dhcp-dns-server' => { optional => 1 }, + 'dhcp-lease-time' => { optional => 1 }, }; } -- 2.47.3