all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 0/2] fix #7606: verify: s3: handle transient fetch errors and add retry
Date: Thu,  3 Sep 2026 14:15:55 +0200	[thread overview]
Message-ID: <20260903121557.420018-1-c.ebner@proxmox.com> (raw)

Transient errors during fetching of object from s3 backend currently
lead to snapshots being marked as verify failed. Subsequent runs of
verification on the same snapshot might succeed without issues, since
chunks are only flagged as bad if the chunk blob object could not be
decoded or content verification failed.

To fix this, discriminate between transient errors and permanent
errors and account for these separately. For snapshots encountering
only transient errors, but no permanent errors during verification,
do not set or strip the verify okay state, but always keep a
pre-existing verification failed state. This is to never allow reuse
of a snapshot as reference for backup/sync jobs, when the state
was bad before and could not be verified again. For the other case
there is not much to loose, if it was okay or not verified before
falling back to not verified reflects the current snapshot state.

Link to the bugtracker issue:
https://bugzilla.proxmox.com/show_bug.cgi?id=7606


proxmox-backup:

Christian Ebner (2):
  fix #7606: verify: s3: handle transient chunk load errors
  verify: s3: retry on transient response body collection errors

 src/backup/verify.rs | 235 ++++++++++++++++++++++++++++++-------------
 1 file changed, 165 insertions(+), 70 deletions(-)


Summary over all repositories:
  1 files changed, 165 insertions(+), 70 deletions(-)

-- 
Generated by murpp 0.11.0




             reply	other threads:[~2026-09-03 12:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 12:15 Christian Ebner [this message]
2026-09-03 12:15 ` [PATCH proxmox-backup 1/2] fix #7606: verify: s3: handle transient chunk load errors Christian Ebner
2026-09-03 12:15 ` [PATCH proxmox-backup 2/2] verify: s3: retry on transient response body collection errors Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260903121557.420018-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal