From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 947F11FF0A7 for ; Wed, 02 Sep 2026 17:00:04 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B4F3621586; Wed, 02 Sep 2026 17:00:00 +0200 (CEST) From: Shan Shaji To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v2 2/6] fix: node: add missing `uptime` property inside the return schema Date: Wed, 2 Sep 2026 16:59:40 +0200 Message-ID: <20260902145944.365185-3-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260902145944.365185-1-s.shaji@proxmox.com> References: <20260902145944.365185-1-s.shaji@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788361192741 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.494 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DAOON7NQJ5CQM5DAUGQG2JAXDIV4HWYS X-Message-ID-Hash: DAOON7NQJ5CQM5DAUGQG2JAXDIV4HWYS X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Earlier, the uptime property was not defined inside the return schema. Because of this, the API types defined inside the pve-api-types crate didn't have the uptime property. In order to access the `uptime` property inside another Rust project, the `additional_properties` map had to be used. To fix this, add uptime property to the return schema. Signed-off-by: Shan Shaji --- PVE/API2/Nodes.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 603f4a06..627e7a2a 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -369,6 +369,12 @@ __PACKAGE__->register_method({ additionalProperties => 1, properties => { # TODO: document remaining ones + uptime => { + type => "integer", + minimum => 0, + description => + "The uptime of the system (including time spent in suspend), in seconds.", + }, idle => { type => "integer", minimum => 0, -- 2.47.3