[RFC qemu 7/9] PVE backup: properly track if snapshot access was set up

[Fiona Ebner <f.ebner@proxmox.com>]

Regular backups set the target ID to "Proxmox". When using QMP
'backup-access-teardown' there is a check to error out when it's not a
regular backup, but this wrongly compared against "Proxmox VE",
rendering the check moot. This should not happen via the Proxmox VE
stack anyway, but still good to fix up. Avoid deciding implicitly
based on the target ID, keep track of whether the backup was set up
for snapshot access or if it is a regular backup explicitly.

In preparation to support different target IDs for regular backups
too.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 pve-backup.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/pve-backup.c b/pve-backup.c
index ad0f8668fd..8a97f0425e 100644
--- a/pve-backup.c
+++ b/pve-backup.c
@@ -74,6 +74,7 @@ static struct PVEBackupState {
     CoMutex backup_mutex;
     CoMutex dump_callback_mutex;
     char *target_id;
+    bool is_backup_access;
 } backup_state;
 
 static void pvebackup_init(void)
@@ -1168,6 +1169,7 @@ BackupAccessInfoList *coroutine_fn qmp_backup_access_setup(
     qemu_mutex_unlock(&backup_state.stat.lock);
 
     backup_state_set_target_id(target_id);
+    backup_state.is_backup_access = true;
 
     backup_state.vmaw = NULL;
     backup_state.pbs = NULL;
@@ -1316,7 +1318,7 @@ void coroutine_fn qmp_backup_access_teardown(const char *target_id, bool success
         return;
     }
 
-    if (!strcmp(backup_state.target_id, "Proxmox VE")) {
+    if (!backup_state.is_backup_access) {
         error_setg(errp, "cannot teardown backup access for PVE - use backup-cancel instead");
         qemu_co_mutex_unlock(&backup_state.backup_mutex);
         return;
@@ -1594,6 +1596,7 @@ UuidInfo coroutine_fn *qmp_backup(
     backup_state.pbs = pbs;
 
     backup_state_set_target_id("Proxmox");
+    backup_state.is_backup_access = false;
 
     backup_state.di_list = di_list;
 
-- 
2.47.3