From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 02FC71FF0A7 for ; Wed, 02 Sep 2026 15:56:48 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9CCF12171E; Wed, 02 Sep 2026 15:55:54 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-backup-qemu 2/9] clippy: commands: avoid manual implementation of ok() Date: Wed, 2 Sep 2026 15:54:33 +0200 Message-ID: <20260902135536.525194-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260902135536.525194-1-f.ebner@proxmox.com> References: <20260902135536.525194-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788357335855 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.765 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AOS4MHMPRJ67TDRRNEMAP44F2P7TSPZC X-Message-ID-Hash: AOS4MHMPRJ67TDRRNEMAP44F2P7TSPZC X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Fiona Ebner --- src/commands.rs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/commands.rs b/src/commands.rs index 565649f..749a0d2 100644 --- a/src/commands.rs +++ b/src/commands.rs @@ -195,14 +195,11 @@ pub(crate) async fn register_image( let index = match manifest { Some(manifest) => { - match client + // not having a previous index is not fatal, so ignore errors, using ok() + client .download_previous_fixed_index(&archive_name, &manifest, Arc::clone(&known_chunks)) .await - { - Ok(index) => Some(index), - // not having a previous index is not fatal, so ignore errors - Err(_) => None, - } + .ok() } None => None, }; -- 2.47.3