From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id BB9331FF0A7 for ; Wed, 02 Sep 2026 15:56:54 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7B48D21733; Wed, 02 Sep 2026 15:55:55 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [RFC qemu-server 9/9] close #6169: backup: pbs: specify target ID so QEMU keeps track of per-target dirty bitmap Date: Wed, 2 Sep 2026 15:54:40 +0200 Message-ID: <20260902135536.525194-10-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260902135536.525194-1-f.ebner@proxmox.com> References: <20260902135536.525194-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788357336395 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.742 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: L3L42XNS7CNUH4LBNKCBGKUTA56HNIYU X-Message-ID-Hash: L3L42XNS7CNUH4LBNKCBGKUTA56HNIYU X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Fiona Ebner --- src/PVE/VZDump/QemuServer.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/VZDump/QemuServer.pm b/src/PVE/VZDump/QemuServer.pm index b1240f8f..8e555817 100644 --- a/src/PVE/VZDump/QemuServer.pm +++ b/src/PVE/VZDump/QemuServer.pm @@ -839,6 +839,12 @@ sub archive_pbs { $params->{'use-dirty-bitmap'} = JSON::true if $qemu_support->{'pbs-dirty-bitmap'} && !$is_template; + my $machine_type = PVE::QemuServer::Machine::get_current_qemu_machine($vmid); + # TODO use correct version for guard! + if (PVE::QemuServer::Machine::is_machine_version_at_least($machine_type, 11, 0)) { + $params->{'target-id'} = "pbs:$opts->{storage}"; + } + $params->{timeout} = 125; # give some time to connect to the backup server $self->loginfo("starting backup via QMP command"); -- 2.47.3