From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 4DC261FF0A7 for ; Wed, 02 Sep 2026 09:43:51 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 61B4921472; Wed, 02 Sep 2026 09:43:43 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH pve-xtermjs 0/3] xterm.js: fix obstructed start button Date: Wed, 2 Sep 2026 09:40:36 +0200 Message-ID: <20260902074338.914500-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.575 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QG7FRQPBL23VAGMYCW3EOPI5SAKS3NED X-Message-ID-Hash: QG7FRQPBL23VAGMYCW3EOPI5SAKS3NED X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The first two patches are just formatting cleanup to make development easier when using proxmox-biome as LSP and the third patch is the actual fix. Not sure how this was broken, I tested this with old chrome/firefox versions and our older xterm.js packages and could still reproduce. Then tested on a PVE 8.4 install and it also happened. (Though with older xterm.js releases it was not as noticable since the default background-color changed in the last few releases) So my current guess is that either something unrelated changed which has an influence on this (desktop environments, etc.) or this was simply broken since a long time. Dominik Csapak (3): xterm.js: add tidy make target xterm.js: run make tidy xterm.js: fix obstructed start button xterm.js/Makefile | 4 + xterm.js/src/index.html.hbs.in | 2 +- xterm.js/src/index.html.tpl.in | 2 +- xterm.js/src/main.js | 562 ++++++++++++++++++--------------- xterm.js/src/style.css | 125 ++++---- xterm.js/src/util.js | 158 ++++----- 6 files changed, 454 insertions(+), 399 deletions(-) -- 2.47.3