From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id B0AF91FF0AE for ; Tue, 01 Sep 2026 09:18:19 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7E064214ED; Tue, 01 Sep 2026 09:18:19 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH manager v3] ui: pool create: allow selecting parent pool via selector Date: Tue, 1 Sep 2026 09:16:58 +0200 Message-ID: <20260901071815.599766-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.592 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HYTVXLHXVGLC4YUEWS6PC2AV5LJIMX6L X-Message-ID-Hash: HYTVXLHXVGLC4YUEWS6PC2AV5LJIMX6L X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: instead of having to type out the full path, e.g. 'foo/bar/baz', show a 'pool selector' to select the parent pool. Forbid using slashes in the name field so it's not possible to specify the structure with both the name and parent pool field. This makes creating nested pools more obvious and easier. Only allow selecting pools up to level 2 as parent, otherwise show a sensible error on the parent field. Signed-off-by: Dominik Csapak --- changes from v2: * disallow pools that are nested too deeply (level >=3) still show them, since it would be too subtle why some are missing www/manager6/dc/PoolEdit.js | 53 +++++++++++++++++++++++-------- www/manager6/form/PoolSelector.js | 19 +++++++++++ 2 files changed, 59 insertions(+), 13 deletions(-) diff --git a/www/manager6/dc/PoolEdit.js b/www/manager6/dc/PoolEdit.js index 72a084ac..3fc17960 100644 --- a/www/manager6/dc/PoolEdit.js +++ b/www/manager6/dc/PoolEdit.js @@ -17,20 +17,47 @@ Ext.define('PVE.dc.PoolEdit', { items: [ { - xtype: 'pmxDisplayEditField', - fieldLabel: gettext('Name'), - cbind: { - editable: '{isCreate}', - value: '{poolid}', + xtype: 'inputpanel', + onGetValues: function (values) { + if (Ext.isString(values.parentPool) && values.parentPool.length > 0) { + values.poolid = values.parentPool + '/' + values.poolid; + } + delete values.parentPool; + return values; }, - name: 'poolid', - allowBlank: false, - }, - { - xtype: 'textfield', - fieldLabel: gettext('Comment'), - name: 'comment', - allowBlank: true, + items: [ + { + xtype: 'pmxDisplayEditField', + fieldLabel: gettext('Name'), + cbind: { + editable: '{isCreate}', + value: '{poolid}', + }, + editConfig: { + regex: /^[^/]+$/, + }, + name: 'poolid', + allowBlank: false, + }, + { + xtype: 'pvePoolSelector', + name: 'parentPool', + fieldLabel: gettext('Parent Pool'), + allowBlank: true, + maxLevel: 2, + emptyText: Proxmox.Utils.NoneText, + cbind: { + disabled: '{!isCreate}', + hidden: '{!isCreate}', + }, + }, + { + xtype: 'textfield', + fieldLabel: gettext('Comment'), + name: 'comment', + allowBlank: true, + }, + ], }, ], diff --git a/www/manager6/form/PoolSelector.js b/www/manager6/form/PoolSelector.js index d4f45622..d265184f 100644 --- a/www/manager6/form/PoolSelector.js +++ b/www/manager6/form/PoolSelector.js @@ -8,6 +8,25 @@ Ext.define( valueField: 'poolid', displayField: 'poolid', + // only allow pools nested up to this level, undefined means allow all + maxLevel: undefined, + + validator: function (value) { + let me = this; + + if (value && me.maxLevel) { + let level = value.split('/').length; + if (level > me.maxLevel) { + return Ext.String.format( + gettext('Selected pool is nested too deep (max level = {0})'), + me.maxLevel, + ); + } + } + + return Proxmox.form.ComboGrid.prototype.validator.call(me, value); + }, + initComponent: function () { var me = this; -- 2.47.3