From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 8A6341FF09B for ; Mon, 31 Aug 2026 14:30:51 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3ADD721628; Mon, 31 Aug 2026 14:30:00 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH manager v4 12/12] ui: qemu: hardware view: inline 'add efi' menuitem Date: Mon, 31 Aug 2026 14:27:47 +0200 Message-ID: <20260831122953.2980232-13-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260831122953.2980232-1-d.csapak@proxmox.com> References: <20260831122953.2980232-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.623 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CROXOSDTUQHFOOP6ABOCGVT7SEQQNRTM X-Message-ID-Hash: CROXOSDTUQHFOOP6ABOCGVT7SEQQNRTM X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: so it's in line with the remaining add buttons. Signed-off-by: Dominik Csapak --- www/manager6/qemu/HardwareView.js | 43 ++++++++++++++++--------------- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 95771ca7..05eb7a3b 100644 --- a/www/manager6/qemu/HardwareView.js +++ b/www/manager6/qemu/HardwareView.js @@ -525,25 +525,6 @@ Ext.define('PVE.qemu.HardwareView', { 'Otherwise, you will be prompted for the BitLocker recovery key on the next boot!', ); - let efidisk_menuitem = Ext.create('Ext.menu.Item', { - text: gettext('EFI Disk'), - iconCls: 'fa fa-fw fa-hdd-o black', - disabled: !caps.vms['VM.Config.Disk'], - handler: function () { - let { data: bios } = me.rstore.getData().map.bios || {}; - - Ext.create('PVE.qemu.EFIDiskEdit', { - autoShow: true, - url: '/api2/extjs/' + baseurl, - pveSelNode: me.pveSelNode, - usesEFI: bios?.value === 'ovmf' || bios?.pending === 'ovmf', - listeners: { - destroy: () => me.reload(), - }, - }); - }, - }); - let counts = {}; let isAtLimit = (type) => counts[type] >= PVE.Utils.hardware_counts[type]; let isAtUsbLimit = () => { @@ -583,7 +564,7 @@ Ext.define('PVE.qemu.HardwareView', { me.down('#addSerial').setDisabled(noVMConfigHWTypePerm || isAtLimit('serial')); me.down('#addNet').setDisabled(noVMConfigNetPerm || isAtLimit('net')); me.down('#addRng').setDisabled(noVMConfigHWTypePerm || isAtLimit('rng')); - efidisk_menuitem.setDisabled(noVMConfigDiskPerm || isAtLimit('efidisk')); + me.down('#addEfi').setDisabled(noVMConfigDiskPerm || isAtLimit('efidisk')); me.down('#addTpmState').setDisabled(noVMConfigDiskPerm || isAtLimit('tpmstate')); me.down('#addVirtiofs').setDisabled(noVMConfigOptionsPerm || isAtLimit('virtiofs')); me.down('#addCloudinitDrive').setDisabled( @@ -865,7 +846,27 @@ Ext.define('PVE.qemu.HardwareView', { disabled: !caps.vms['VM.Config.Disk'], handler: editorFactory('HDEdit', { importDisk: true }), }, - efidisk_menuitem, + { + itemId: 'addEfi', + text: gettext('EFI Disk'), + iconCls: 'fa fa-fw fa-hdd-o black', + disabled: !caps.vms['VM.Config.Disk'], + handler: function () { + let { data: bios } = me.rstore.getData().map.bios || {}; + + Ext.create('PVE.qemu.EFIDiskEdit', { + autoShow: true, + url: '/api2/extjs/' + baseurl, + pveSelNode: me.pveSelNode, + usesEFI: + bios?.value === 'ovmf' || + bios?.pending === 'ovmf', + listeners: { + destroy: () => me.reload(), + }, + }); + }, + }, { text: gettext('TPM State'), itemId: 'addTpmState', -- 2.47.3