From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 2DADC1FF0DF for ; Fri, 28 Aug 2026 15:32:14 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id AE123216AD; Fri, 28 Aug 2026 15:31:13 +0200 (CEST) From: Shannon Sterz To: pve-devel@lists.proxmox.com Subject: [PATCH installer 20/21] tui-installer: unmount a potentially mounted backup on abort Date: Fri, 28 Aug 2026 15:30:29 +0200 Message-ID: <20260828133030.351140-21-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260828133030.351140-1-s.sterz@proxmox.com> References: <20260828133030.351140-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787923825265 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.881 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WRGJG7C5JNDDDAXBSITMNO5T6EBK4LIW X-Message-ID-Hash: WRGJG7C5JNDDDAXBSITMNO5T6EBK4LIW X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Shannon Sterz --- proxmox-tui-installer/src/main.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/proxmox-tui-installer/src/main.rs b/proxmox-tui-installer/src/main.rs index 1f3e8fe..c23be46 100644 --- a/proxmox-tui-installer/src/main.rs +++ b/proxmox-tui-installer/src/main.rs @@ -346,6 +346,8 @@ fn prompt_dialog( } fn trigger_abort_install_dialog(siv: &mut Cursive) { + #[cfg(debug_assertions)] + let _ = siv.with_user_data(|state| crate::views::ensure_no_mounted_backup(state)); #[cfg(debug_assertions)] siv.quit(); @@ -355,7 +357,11 @@ fn trigger_abort_install_dialog(siv: &mut Cursive) { "Abort installation?", "Are you sure you want to abort the installation?", "Yes", - Box::new(Cursive::quit), + Box::new(|siv| { + // Ignore unmounting errors to ensure aborting finishes. + let _ = siv.with_user_data(|state| crate::views::ensure_no_mounted_backup(state)); + Cursive::quit(siv); + }), "No", Box::new(|_| {}), ) -- 2.47.3