From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id F03541FF0DF for ; Fri, 28 Aug 2026 13:33:31 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1B39E215F3; Fri, 28 Aug 2026 13:33:06 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-perl-rs v3 06/13] pve-rs: fabrics: add IS-IS protocol ifupdown config generation Date: Fri, 28 Aug 2026 13:32:45 +0200 Message-ID: <20260828113255.176546-7-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260828113255.176546-1-g.goller@proxmox.com> References: <20260828113255.176546-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787916770752 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.502 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7A5HHWWZQ7CTGOFHLM2OZ3P3GYWLDEWD X-Message-ID-Hash: 7A5HHWWZQ7CTGOFHLM2OZ3P3GYWLDEWD X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Generate the interfaces that have been configured with IS-IS to the ifupdown config (enable ip-forwarding on all). IS-IS needs to have the ip-address duplicated from the dummy interface to every interface in unnumbered mode (like with ospf). This could potentially be fixed in the future with [0]. [0]: https://github.com/FRRouting/frr/pull/19429 Signed-off-by: Gabriel Goller --- pve-rs/src/bindings/sdn/fabrics.rs | 44 ++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/pve-rs/src/bindings/sdn/fabrics.rs b/pve-rs/src/bindings/sdn/fabrics.rs index f96b6b1c656f..33ed92cfd033 100644 --- a/pve-rs/src/bindings/sdn/fabrics.rs +++ b/pve-rs/src/bindings/sdn/fabrics.rs @@ -400,6 +400,13 @@ pub mod pve_rs_sdn_fabrics { } } } + ConfigNode::Isis(node_section) => { + for interface in node_section.properties_mut().interfaces_mut() { + if let Some(mapped_name) = map_name(&mapping, interface.name())? { + interface.set_name(mapped_name); + } + } + } ConfigNode::Ospf(node_section) => { for interface in node_section.properties_mut().interfaces_mut() { if let Some(mapped_name) = map_name(&mapping, interface.name())? { @@ -513,6 +520,9 @@ pub mod pve_rs_sdn_fabrics { FabricEntry::Bgp(_) => { daemons.insert("bgpd"); } + FabricEntry::Isis(_) => { + daemons.insert("isisd"); + } }; } @@ -681,6 +691,40 @@ pub mod pve_rs_sdn_fabrics { } } } + ConfigNode::Isis(node_section) => { + for interface in node_section.properties().interfaces() { + if let Some(ip) = interface.ip() { + let interface = + render_interface(interface.name(), Cidr::from(ip), None)?; + writeln!(interfaces)?; + write!(interfaces, "{interface}")?; + } + if let Some(ip) = interface.ip6() { + let interface = + render_interface(interface.name(), Cidr::from(ip), None)?; + writeln!(interfaces)?; + write!(interfaces, "{interface}")?; + } + + // If no ip is configured, add auto and iface with node ip to bring + // interface up ISIS doesn't really need an ip on the interface, but the + // problem is that arp can't tell which source address to use in some + // cases, so it's better if we set the node address on all the fabric + // interfaces. + if let (None, None) = (interface.ip(), interface.ip6()) { + let cidr = Cidr::from(if let Some(ip) = node.ip() { + IpAddr::from(ip) + } else if let Some(ip) = node.ip6() { + IpAddr::from(ip) + } else { + anyhow::bail!("there has to be a ipv4 or ipv6 node address"); + }); + let interface = render_interface(interface.name(), cidr, None)?; + writeln!(interfaces)?; + write!(interfaces, "{interface}")?; + } + } + } ConfigNode::Ospf(node_section) => { for interface in node_section.properties().interfaces() { writeln!(interfaces)?; -- 2.47.3